Fix compiling error when missing gdbm version macros #7823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Jun 20, 2018
| @@ -527,11 +527,11 @@ def collect_cc(info_add): | |||
|
|
|||
| def collect_gdbm(info_add): | |||
| try: | |||
| import _gdbm | |||
| from _gdbm import _GDBM_VERSION | |||
There was a problem hiding this comment.
@serhiy-storchaka will be happy of this change :-D To be honest, I only saw this comment after I merged my PR :-(
|
Lol. Do you have any mind why the VSTS CI fails and how to restart it? |
No idea, but it's not the first time that I see the error today. So I created: https://bugs.python.org/issue33915
Close/reopen the issue. But I would suggest you to ignore the VSTS failures, the CI is unstable and not required yet. |
|
VSTS as all other CIs are now happy. |
|
Thanks @vstinner :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.