bpo-33721: Make some os.path functions and pathlib.Path methods be tolerant to invalid paths. #7695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such functions as os.path.exists(), os.path.lexists(), os.path.isdir(), os.path.isfile(), os.path.islink(), and os.path.ismount() now return False instead of raising ValueError or its subclasses UnicodeEncodeError and UnicodeDecodeError for paths that contain characters or bytes unrepresntative at the OS level.
serhiy-storchaka
force-pushed
the
os-path-invalid
branch
from
a9dc0c8 to
dba3f82
Compare
vadmium
reviewed
Aug 19, 2018
|
Thank you for your review @vadmium! |
serhiy-storchaka
changed the title
|
@serhiy-storchaka: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such functions as
os.path.exists(),os.path.lexists(),os.path.isdir(),os.path.isfile(),os.path.islink(), andos.path.ismount()now returnFalseinstead of raisingValueErroror its subclassesUnicodeEncodeErrorandUnicodeDecodeErrorfor paths that contain characters or bytes unrepresntative at the OS level.https://bugs.python.org/issue33721