[Skip Issue] Add missing va_end() calls in PC/launcher.c #7690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willingc
reviewed
Jun 14, 2018
Contributor
willingc
left a comment
willingc
left a comment
There was a problem hiding this comment.
Thanks for the PR @ZackerySpytz.
This looks good to me. I'll leave this for one of our Windows experts to approve and merge.
Contributor
|
Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
Member
|
Thanks, @ZackerySpytz! |
|
GH-7732 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2018
(cherry picked from commit 3a6d752) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-7733 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2018
(cherry picked from commit 3a6d752) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jun 15, 2018
(cherry picked from commit 3a6d752) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Contributor
|
Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-7779 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 18, 2018
(cherry picked from commit 3a6d752) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jun 18, 2018
(cherry picked from commit 3a6d752) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every call to
va_start()must be matched with a call tova_end().