Skip to content

bpo-33836: Fix code example in the documentation. #7687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2018
Merged

bpo-33836: Fix code example in the documentation. #7687

merged 1 commit into from
Jun 16, 2018

Conversation

@noahhaasis
Copy link
Contributor

@noahhaasis noahhaasis commented Jun 14, 2018 •
edited by bedevere-bot
Loading

bpo-33836: I changed a function signature in the doc about cashing and updated the corresponding [https://bugs.python.org/issue33836]

https://bugs.python.org/issue33836

@Mariatta Mariatta added docs Documentation in the Doc dir needs backport to 3.6 skip news labels Jun 16, 2018
@Mariatta Mariatta merged commit 2707e41 into python:master Jun 16, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Jun 16, 2018

Thanks @noahhaasis for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Mariatta commented Jun 16, 2018

Thanks @noahhaasis and congrats on your first contribution to CPython 🌮

@bedevere-bot
Copy link

bedevere-bot commented Jun 16, 2018

GH-7742 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2018
@noahhaasis @miss-islington
bpo-33836: Recommend keyword-only param for memoization in FAQ (pytho…
fd1bae9 
…nGH-7687)

Update the the signature in the code example to make `_cache` a keyword-only parameter.
(cherry picked from commit 2707e41)

Co-authored-by: Noah Haasis <haasis_noah@yahoo.de>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2018
@noahhaasis @miss-islington
bpo-33836: Recommend keyword-only param for memoization in FAQ (pytho…
b439d8b 
…nGH-7687)

Update the the signature in the code example to make `_cache` a keyword-only parameter.
(cherry picked from commit 2707e41)

Co-authored-by: Noah Haasis <haasis_noah@yahoo.de>
@bedevere-bot
Copy link

bedevere-bot commented Jun 16, 2018

GH-7743 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Jun 16, 2018
@miss-islington @noahhaasis
bpo-33836: Recommend keyword-only param for memoization in FAQ (GH-7687)
5a0bf74 
Update the the signature in the code example to make `_cache` a keyword-only parameter.
(cherry picked from commit 2707e41)

Co-authored-by: Noah Haasis <haasis_noah@yahoo.de>
miss-islington added a commit that referenced this pull request Jun 16, 2018
@miss-islington @noahhaasis
bpo-33836: Recommend keyword-only param for memoization in FAQ (GH-7687)
2636833 
Update the the signature in the code example to make `_cache` a keyword-only parameter.
(cherry picked from commit 2707e41)

Co-authored-by: Noah Haasis <haasis_noah@yahoo.de>
@noahhaasis noahhaasis deleted the fix-issue-33836 branch June 16, 2018 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@noahhaasis @miss-islington @Mariatta @bedevere-bot @the-knights-who-say-ni