Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GCC warning in Python/hamt.c #7618

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Fix GCC warning in Python/hamt.c #7618

merged 1 commit into from
Jul 6, 2018

Conversation

ZackerySpytz
Copy link
Contributor

This warning is present in the Travis builds for master and 3.7.

Python/hamt.c: In function ‘_PyHamt_Without’:
Python/hamt.c:2371:76: warning: ‘new_root’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Py_DECREF(new_root);
^
Python/hamt.c: In function ‘hamt_py_delete’:
Python/hamt.c:2371:76: warning: ‘new_root’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Python/hamt.c:2351:17: note: ‘new_root’ was declared here
PyHamtNode *new_root;

@ZackerySpytz ZackerySpytz requested a review from 1st1 as a code owner June 11, 2018 06:03
@zhangyangyu zhangyangyu changed the title [Skip Issue] Fix GCC warning (-Wmaybe-uninitialized) in Python/hamt.c Fix GCC warning (-Wmaybe-uninitialized) in Python/hamt.c Jun 27, 2018
@methane methane changed the title Fix GCC warning (-Wmaybe-uninitialized) in Python/hamt.c Fix GCC warning in Python/hamt.c Jul 6, 2018
@methane methane merged commit d8c3e82 into python:master Jul 6, 2018
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-8135 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2018
@ZackerySpytz @miss-islington
Fix GCC warning in Python/hamt.c (pythonGH-7618)
b010b4b 
(cherry picked from commit d8c3e82)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jul 6, 2018
@miss-islington @ZackerySpytz
Fix GCC warning in Python/hamt.c (GH-7618)
625755e 
(cherry picked from commit d8c3e82)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@ZackerySpytz ZackerySpytz deleted the gcc_warning_hamt branch July 12, 2018 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZackerySpytz @miss-islington @bedevere-bot @methane @zhangyangyu @the-knights-who-say-ni