Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33818: PyExceptionClass_Name() will now return "const char *". #7581

Merged
merged 4 commits into from
Jun 15, 2018
Merged

bpo-33818: PyExceptionClass_Name() will now return "const char *". #7581

merged 4 commits into from
Jun 15, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 10, 2018 •
edited by bedevere-bot
Loading

This PR is purposed for backporting in 3.7. If this change will not be applied to 3.7, What's New will need to be changed.

https://bugs.python.org/issue33818

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Jun 10, 2018
ned-deily
ned-deily requested changes Jun 10, 2018
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted on the bug issue, I do not see a compelling reason to introduce this interface change at this very late stage of the 3.7.0 release. Let's target it for 3.8.

Also, note that the "make suspicious" check failed.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@ned-deily
Copy link
Member

I should note that I believe this arose because of the changes for bpo-33738 (#7585) which are trying to make the stable ABI usable again. As I understand it, the change there should have minimal user impact as the stable ABI is obviously not being used with current versions of 3.x.

@serhiy-storchaka
Copy link
Member Author

Re-targeted for 3.8. I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@serhiy-storchaka serhiy-storchaka merged commit ceeef10 into python:master Jun 15, 2018
@serhiy-storchaka serhiy-storchaka deleted the PyExceptionClass_Name-const-char branch June 15, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @bedevere-bot @ned-deily @the-knights-who-say-ni