Skip to content

A better fix for asyncio test_stdin_broken_pipe #7221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2018
Merged

A better fix for asyncio test_stdin_broken_pipe #7221

merged 2 commits into from
May 30, 2018

Conversation

1st1
Copy link
Member

@1st1 1st1 commented May 29, 2018

No description provided.

@1st1 1st1 requested a review from vstinner May 29, 2018 20:55
@1st1 1st1 requested a review from gpshead as a code owner May 29, 2018 20:55
asvetlov
asvetlov reviewed May 29, 2018
View reviewed changes
Lib/test/test_asyncio/test_subprocess.py Outdated
@@ -1,5 +1,7 @@
import os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps os and time modules are not needed anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@1st1 1st1 merged commit ad74d50 into python:master May 30, 2018
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@1st1: Please replace # with GH- in the commit message next time. Thanks!

@1st1 1st1 deleted the betterfixci branch May 30, 2018 00:57
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2018
@1st1 @miss-islington
A better fix for asyncio test_stdin_broken_pipe (pythonGH-7221)
ff15ca2 
(cherry picked from commit ad74d50)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot
Copy link

GH-7234 is a backport of this pull request to the 3.7 branch.

1st1 added a commit to 1st1/cpython that referenced this pull request May 30, 2018
@1st1
Revert "A better fix for asyncio test_stdin_broken_pipe (python#7221)"
7d53ef4 
This reverts commit ad74d50.

Turns out it's not a good fix -- Travis has just crashed on this test.
1st1 added a commit that referenced this pull request May 30, 2018
@1st1
Revert "A better fix for asyncio test_stdin_broken_pipe (GH-7221)" (G…
bb9474f 
…H-7235)

This reverts commit ad74d50.

Turns out it's not a good fix -- Travis has just crashed on this test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov left review comments

@vstinner vstinner Awaiting requested review from vstinner

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1st1 @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni