gh-47655: Add support for user data of Tk virtual events to tkinter #7142
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
|
I see a "Contributor Form Received: Yes" now on my account on bpo. So CLA has arrived. |
|
@the-knights-who-say-ni , what is missing? Why it is not accepted yet?
Those erros are not related to tkinter |
|
I have not seen any news about this issue after the migration, but it looks like this is the most complete patch. @serhiy-storchaka could anything else be done to help with this review? |
|
This PR is stale because it has been open for 30 days with no activity. |
| @@ -1732,11 +1736,14 @@ def getint_event(s): | |||
| if any(isinstance(s, tuple) for s in args): | |||
| args = [s[0] if isinstance(s, tuple) and len(s) == 1 else s | |||
| for s in args] | |||
| nsign, b, f, h, k, s, t, w, x, y, A, E, K, N, W, T, X, Y, D = args | |||
| # Missing: (a, c, d, m, o, v, B, R) | |||
| nsign, b, d, f, h, k, s, t, w, x, y, A, E, K, N, W, T, X, Y, D = args | |||
There was a problem hiding this comment.
Is it breaking change? Because f argument is moved one position to the right and number of arguments is changed. Just making a point in case you have missed it.
There was a problem hiding this comment.
Also, d is no longer missing, comment lies.
github-actions
bot
removed
the
stale
picnixz
changed the title
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
This adds Tk %d event field as 'detail' and 'user_data' attributes to tkinter events.
I have not yet changed the documentation, because I am not sure about the intent
of the table in "25.1.6.7. Bindings and Events" in tkinter documentation.
If supposed to be complete, I suggest also adding the other three missing fields (%#, %b, %D).
I have added a simple test of virtual events and the userdata attribute including bind/unbind.
To make the test possible I use a pump_events function found on
stackoverflow (https://stackoverflow.com/questions/4083796/how-do-i-run-unittest-on-a-tkinter-app/49028688#49028688).
Note, I tested this only on Debian Linux.
Also, I had spurious "Bad Drawable" errors from the X server running the tkinter unittest,
but I have those in the same way on the changed and unchanged Python.
Seems to be my non-mainstream setup (ctwm with interactive window placement).
This is my first pull request. Sorry, if I have forgotten obvious things.
https://bugs.python.org/issue3405