Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missed details of the C API introduced in 3.7. #7047

Merged
merged 1 commit into from
May 22, 2018
Merged

Add missed details of the C API introduced in 3.7. #7047

merged 1 commit into from
May 22, 2018

Conversation

serhiy-storchaka
Copy link
Member

  • Set the limited API version for PyImport_GetModule and PyOS_*Fork functions.
  • Add PyImport_GetModule and Py_UTF8Mode in PC/python3.def.
  • Add several functions in Doc/data/refcounts.dat.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error skip news needs backport to 3.7 labels May 22, 2018
@serhiy-storchaka serhiy-storchaka requested a review from a team as a code owner May 22, 2018 09:42
@serhiy-storchaka
Add missed details of the C API introduced in 3.7.
f3aa24c 
* Set the limited API version for PyImport_GetModule and PyOS_*Fork
  functions.
* Add PyImport_GetModule and Py_UTF8Mode in PC/python3.def.
* Add several functions in Doc/data/refcounts.dat.
ericsnowcurrently
ericsnowcurrently approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this! Sorry I missed it.

@serhiy-storchaka serhiy-storchaka merged commit 4e29f56 into python:master May 22, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the capi-37 branch May 22, 2018 17:59
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4e29f566e8821c09d8274eadcdd355e8b1284b8b 3.7

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 22, 2018
@serhiy-storchaka
[3.7] Add missed details of the C API introduced in 3.7. (pythonGH-7047)
58a3991 
* Set the limited API version for PyImport_GetModule and PyOS_*Fork
  functions.
* Add PyImport_GetModule and Py_UTF8Mode in PC/python3.def.
* Add several functions in Doc/data/refcounts.dat..
(cherry picked from commit 4e29f56)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-7061 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request May 22, 2018
@serhiy-storchaka
[3.7] Add missed details of the C API introduced in 3.7. (GH-7047) (G…
1f22a30 
…H-7061)

* Set the limited API version for PyImport_GetModule and PyOS_*Fork
  functions.
* Add PyImport_GetModule and Py_UTF8Mode in PC/python3.def.
* Add several functions in Doc/data/refcounts.dat.
(cherry picked from commit 4e29f56)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@ned-deily ned-deily ned-deily approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@serhiy-storchaka @miss-islington @bedevere-bot @1st1 @ericsnowcurrently @ned-deily @the-knights-who-say-ni