bpo-33516: Add support for __round__ to MagicMock #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
May 17, 2018
|
For Travis CI, your PR has be bitten by https://bugs.python.org/issue33531 :-( |
amyreese
force-pushed
the
round
branch
3 times, most recently
from
f9cd107
to
92c03e2
Compare
|
Added unit tests for round/trunc/floor/ceil, and fixed docs build. |
vstinner
reviewed
May 18, 2018
| self.assertTrue(round(mock)) | ||
| self.assertTrue(math.trunc(mock)) | ||
| self.assertTrue(math.floor(mock)) | ||
| self.assertTrue(math.ceil(mock)) |
There was a problem hiding this comment.
The result of round(), trunc(), etc. are a number, not a boolean. You should use assertEqual(..., value) instead.
There was a problem hiding this comment.
Updated to assert equal to mock.__dunder__() calls.
vstinner
approved these changes
May 22, 2018
| @@ -0,0 +1,2 @@ | |||
| Add ``__round__`` to the list of magic methods supported by | |||
There was a problem hiding this comment.
Oh, you didn't mention the module. Please add "unittest.mock: " prefix to this NEWS entry.
|
Updated/reworded news entry to link to unittest.mock.MagicMock. |
|
Thanks @jreese, the change now LGTM. The final version is better than the first version ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
__round__to MagicMock.https://bugs.python.org/issue33516