Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33497: Add errors param to cgi.parse_multipart and make an encoding in FieldStorage use the given errors #6804

Merged
merged 4 commits into from
May 14, 2018
Merged

bpo-33497: Add errors param to cgi.parse_multipart and make an encoding in FieldStorage use the given errors #6804

merged 4 commits into from
May 14, 2018

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented May 14, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@zooba
Copy link
Member

zooba commented May 14, 2018

@hawkowl The change looks good to me - can you click "Details" on that failed check and follow the instructions to add the NEWS entry? (It's very easy - thank Larry :) )

@ned-deily I think this is fine, but I'll leave it to you to merge/backport (feel free to remove the label)

@hawkowl
Copy link
Contributor Author

hawkowl commented May 14, 2018

(sorry I couldn't resist)

multipart

@hawkowl
Copy link
Contributor Author

hawkowl commented May 14, 2018

@zooba it'd be easier with towncrier ;) -- but, I don't think it needs a new news entry, from looking at the details?

@hawkowl
Copy link
Contributor Author

hawkowl commented May 14, 2018

(it doesn't need one as it's under a current 'what's new', I think?)

@ned-deily ned-deily merged commit 545c955 into python:master May 14, 2018
@miss-islington
Copy link
Contributor

Thanks @hawkowl for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2018
@hawkowl @miss-islington
bpo-33497: Add errors param to cgi.parse_multipart and make an encodi…
4481c4b 
…ng in FieldStorage use the given errors (pythonGH-6804)

(cherry picked from commit 545c955)

Co-authored-by: Amber Brown <hawkowl@atleastfornow.net>
@bedevere-bot
Copy link

GH-6837 is a backport of this pull request to the 3.7 branch.

ned-deily pushed a commit that referenced this pull request May 14, 2018
@miss-islington @hawkowl @ned-deily
bpo-33497: Add errors param to cgi.parse_multipart and make an encodi…
e8f968d 
…ng in FieldStorage use the given errors (GH-6804) (GH-6837)

(cherry picked from commit 545c955)

Co-authored-by: Amber Brown <hawkowl@atleastfornow.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hawkowl @the-knights-who-say-ni @zooba @miss-islington @bedevere-bot @ned-deily