bpo-33455: Pass os.environ in test_posix::test_specify_environment #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix LGTM, but I don't think it is worth a news entry. News entries usually are added only for changes that affect many tests like adding new CLI option or new helper in test.support. |
|
Oh, I tough the news entry is mandatory. |
|
Usually yes, but we have a special label for the case when it is not required. |
Pass os.environ's copy to new process created at test_posix: test_specify_environment. Otherwise important variables such as LD_LIBRARY_PATH are not set and the child process might not work at all in an environment where such variables are required for Python to function.
|
Amended. |
serhiy-storchaka
approved these changes
May 10, 2018
|
Thanks for the swift review. |
|
Thank you for your report and fix! |
|
Thanks @hroncok for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2018
…ythonGH-6753) Pass os.environ's copy to new process created at test_posix: test_specify_environment. Otherwise important variables such as LD_LIBRARY_PATH are not set and the child process might not work at all in an environment where such variables are required for Python to function. (cherry picked from commit 7ec8f28) Co-authored-by: Miro Hrončok <miro@hroncok.cz>
|
GH-6765 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
May 11, 2018
…H-6753) Pass os.environ's copy to new process created at test_posix: test_specify_environment. Otherwise important variables such as LD_LIBRARY_PATH are not set and the child process might not work at all in an environment where such variables are required for Python to function. (cherry picked from commit 7ec8f28) Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
os.environ's copy to new process created attest_posix::test_specify_environment. Otherwise important variables such asLD_LIBRARY_PATHare not set and the child process might not work at allin an environment where such variables are required for Python to function.
https://bugs.python.org/issue33455