Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33311: Do not display parameters displayed in parentheses for module call #6677

Merged
merged 3 commits into from
May 9, 2018
Merged

bpo-33311: Do not display parameters displayed in parentheses for module call #6677

merged 3 commits into from
May 9, 2018

Conversation

sblondon
Copy link
Contributor

@sblondon sblondon commented May 1, 2018 •
edited by bedevere-bot
Loading

This PR removes the parentheses if the trace is in module directly.

The parentheses and parameters are kept otherwise.

https://bugs.python.org/issue33311

serhiy-storchaka
serhiy-storchaka reviewed May 8, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard to write tests for this?

Misc/NEWS.d/next/Library/2018-05-01-22-33-14.bpo-33311.8YPB-k.rst Outdated
@@ -0,0 +1,2 @@
Text and html output generated by cgitb does not display parentheses if the
current call is done directly in the module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed period. Please add "Patch by yourname."

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label May 9, 2018
@serhiy-storchaka serhiy-storchaka merged commit 8cf4b34 into python:master May 9, 2018
@sblondon sblondon deleted the parentheses-removal-for-module-call branch May 10, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sblondon @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot