Skip to content

bpo-33352: Skip test if rt.bat does not exist #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2018
Merged

bpo-33352: Skip test if rt.bat does not exist #6654

merged 1 commit into from
Apr 30, 2018

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Apr 30, 2018 •
edited by bedevere-bot
Loading

vstinner
vstinner approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit c3b7a6d into python:master Apr 30, 2018
@vstinner
Copy link
Member

Thanks. I just added "test_regrest" to the commit message.

@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-6656 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2018
@andresdelfino @miss-islington
bpo-33352: Skip test_regrtest test if rt.bat does not exist (pythonGH…
f978c12 
…-6654)

(cherry picked from commit c3b7a6d)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
vstinner pushed a commit that referenced this pull request Apr 30, 2018
@miss-islington @andresdelfino @vstinner
bpo-33352: Skip test_regrtest test if rt.bat does not exist (GH-6654) (…
8075868 
…#6656)

(cherry picked from commit c3b7a6d)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the fix-test_pcbuild_rt branch May 1, 2018 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andresdelfino @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni