Skip to content

[3.7] bpo-33358: Fix test_embed.test_pre_initialization_sys_options (GH-6612) #6618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2018
Merged

[3.7] bpo-33358: Fix test_embed.test_pre_initialization_sys_options (GH-6612) #6618

merged 1 commit into from
Apr 27, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 27, 2018 •
edited by bedevere-bot
Loading

Fix test_embed.test_pre_initialization_sys_options() when building with --enable-shared
(cherry picked from commit 4114846)

Co-authored-by: Pablo Galindo Pablogsal@gmail.com

https://bugs.python.org/issue33358

@pablogsal @miss-islington
bpo-33358: Fix test_embed.test_pre_initialization_sys_options (python…
9ba7e04 
…GH-6612)

Fix test_embed.test_pre_initialization_sys_options() when building with --enable-shared
(cherry picked from commit 4114846)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Apr 27, 2018
Merged
vstinner
vstinner approved these changes Apr 27, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner
Copy link
Member

I tested manually Python 3.7 with --enabled-shared: test_embed fails without this change, and pass with this change.

@vstinner
Copy link
Member

cc @pablogsal

@miss-islington
Copy link
Contributor Author

@pablogsal and @vstinner: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit dd3ede7 into python:3.7 Apr 27, 2018
@miss-islington
Copy link
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-4114846-3.7 branch April 27, 2018 12:41
@vstinner
Copy link
Member

@pablogsal and @vstinner: Backport status check is done, and it's a success white_check_mark .

Oh wow, that was fast. Now I really saw that bot doing an actual merge. Impressive work @Mariatta!

@vstinner
Copy link
Member

Thanks again, good bot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @pablogsal