[2.7] bpo-33280: Reorganize external Tcl/Tk references. (GH-6473). #6603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge. :mod: |
terryjreedy
reviewed
Jun 25, 2018
| @@ -11,6 +11,11 @@ the Tk GUI toolkit. Both Tk and :mod:`Tkinter` are available on most Unix | |||
| platforms, as well as on Windows systems. (Tk itself is not part of Python; it | |||
| is maintained at ActiveState.) | |||
|
|
|||
| Running ``python -m Tkinter`` from the command line should open a window | |||
| demonstrating a simple Tk interface, letting you know that :mod:`tkinter` is | |||
There was a problem hiding this comment.
The only change needed before merging this is Tkinter instead of tkinter here
| @@ -11,6 +11,11 @@ the Tk GUI toolkit. Both Tk and :mod:`Tkinter` are available on most Unix | |||
| platforms, as well as on Windows systems. (Tk itself is not part of Python; it | |||
| is maintained at ActiveState.) | |||
|
|
|||
| Running ``python -m Tkinter`` from the command line should open a window | |||
There was a problem hiding this comment.
I verified that this works on 2.7 and displays the tk version.
|
Sorry, I should have added a note. This was followed in #6607 |
|
I believe this was my first backport. Back then, I didn't knew I could checkout a remote branch to resume working on it (as cherry_picker deletes the branch after pushing it). That's why I decided to make another PR, close this one and delete the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 67a8f4f)
Co-authored-by: Andrés Delfino 34587441+andresdelfino@users.noreply.github.com
https://bugs.python.org/issue33280