bpo-991266: Fix quoting of the Comment attribute of SimpleCookie #6555
Conversation
| @@ -408,6 +408,8 @@ def OutputString(self, attrs=None): | |||
| append("%s=%s" % (self._reserved[key], _getdate(value))) | |||
| elif key == "max-age" and isinstance(value, int): | |||
| append("%s=%d" % (self._reserved[key], value)) | |||
| elif key == "comment" and isinstance(value, str): | |||
| append("%s=%s" % (self._reserved[key], _quote(value))) | |||
There was a problem hiding this comment.
This patch looks like it correctly solves this problem, however is there a reason not to quote all values? (line417)
There was a problem hiding this comment.
Like I said in the issue (https://bugs.python.org/issue991266#msg315499) I'm a bit reluctant on that idea. The situation with cookie specs is a bit painful to deal :) Also, I'm not sure we can do that in bugfix releases because of backwards compatibility reasons.
Perhaps we can be a little bit conservative and merge this for now and discuss (like taking a look at other programming languages) a broader change like you and Mark mentioned in the issue for 3.8? I wrote this patch almost two years ago and to be honest I don't remember RFC 6265 and other relevant specs (2109, 2068 etc.) anymore :)
There was a problem hiding this comment.
Ok, I'm fine to 👍 this since it is correct.
|
Thanks @berkerpeksag for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-6570 is a backport of this pull request to the 3.7 branch. |
|
GH-6571 is a backport of this pull request to the 3.6 branch. |
(cherry picked from commit d5a2377) Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
(cherry picked from commit d5a2377) Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
https://bugs.python.org/issue991266