Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33262: Deprecate passing None for s to shlex.split() #6514

Merged
merged 6 commits into from
Apr 1, 2020
Merged

bpo-33262: Deprecate passing None for s to shlex.split() #6514

merged 6 commits into from
Apr 1, 2020

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Apr 17, 2018 •
edited by bedevere-bot
Loading

@ZackerySpytz
bpo-33262: Deprecate passing None for s to shlex.split()
a1b35aa 
This reads the string to split from standard input.
@matrixise
Copy link
Member

Hi @ZackerySpytz

Thank you for your PR and your time.

serhiy-storchaka
serhiy-storchaka requested changes Oct 12, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add also an entry in the What's New document.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

pganssle
pganssle reviewed Apr 25, 2019
View reviewed changes
@csabella csabella requested a review from serhiy-storchaka May 31, 2019 11:25
@csabella
Copy link
Contributor

@ZackerySpytz, please address @pganssle's comment. Thanks!

@csabella
Copy link
Contributor

@ZackerySpytz, this looks like it was close to being merged. Please take a look at the last code review. Thanks!

@pganssle pganssle self-requested a review March 29, 2020 16:06
pganssle
pganssle approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume the test failures are unrelated? Happy to merge once we have them green.

@ZackerySpytz
Copy link
Contributor Author

Yes, the CI failures were unrelated (I see errors like Git checkout failed with exit code: 128). Everything is green now.

@pganssle pganssle merged commit 975ac32 into python:master Apr 1, 2020
@pganssle
Copy link
Member

pganssle commented Apr 1, 2020

Great, thanks @ZackerySpytz!

@tiran tiran mentioned this pull request Jun 28, 2022
Closed
@furkanonder
Copy link
Contributor

@pganssle The issue seems to be solved. We can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrixise matrixise matrixise approved these changes

@pganssle pganssle pganssle approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

@ZackerySpytz ZackerySpytz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ZackerySpytz @matrixise @bedevere-bot @csabella @pganssle @furkanonder @serhiy-storchaka @the-knights-who-say-ni