bpo-33297: Mention Pillow to work with more image formats #6505

andresdelfino · 2018-04-17T11:12:28Z

https://bugs.python.org/issue33297

terryjreedy · 2018-04-17T22:14:36Z

Looks good to me, but tkinter doc changes are Serhiy's call.

serhiy-storchaka · 2018-04-18T08:42:30Z

Doc/library/tkinter.rst

@@ -799,6 +799,10 @@ reference to the image. When the last Python reference to the image object is
 deleted, the image data is deleted as well, and Tk will display an empty box
 wherever the image was used.

+.. seealso::
+
+    The `Pillow package <https://pillow.readthedocs.io/>`_ adds support for


The home page of Pillow is http://python-pillow.org/.

And I think that the link should be from just Pillow.

Home page updated, I don't understand what you mean by "the link should be from just Pillow".

Oh, you mean it should be rendered as: "The <a ...>Pillow package"?

@serhiy-storchaka the comment you made "the link should be from just Pillow" remains unaddressed. Could you please elaborate?

I thought it would look better as

The `Pillow <http://python-pillow.org/>`_ package

But this is not strong preference.

Yes, I agree. I'll change it.

serhiy-storchaka · 2018-04-18T08:47:25Z

While we are here, it would be worth to replace other mentions of PIL (wich doesn't support Python 3) with Pillow.

andresdelfino · 2018-04-18T11:02:43Z

@serhiy-storchaka I have updated a couple of references to PIL. Found the following references too, but I'm not really sure these should be updated:

cpython\Doc\c-api\buffer.rst
cpython\Include\memoryobject.h
cpython\Lib\test\test_buffer.py
cpython\Modules\Setup.dist
cpython\Modules_testbuffer.c
cpython\Modules\tkappinit.c
cpython\setup.py

serhiy-storchaka

There is mention of PIL.Image in Doc/faq/programming.rst.

serhiy-storchaka · 2018-04-18T18:19:51Z

Doc/distutils/introduction.rst

-   Library), or mxBase.  (This would be called a *package*, except that term is
-   already taken in the Python context: a single module distribution may contain
-   zero, one, or many Python packages.)
+   module distributions are NumPy, SciPy, Pillow, or mxBase.  (This would be


Please avoid rewrapping lines if this is not needed. It is not so bad if some lines will become short after deletion.

Got it, sorry!

Should I revert the wrapping of these lines?

Yes, please.

serhiy-storchaka · 2018-04-18T18:23:02Z

Doc/library/tkinter.rst

@@ -799,6 +799,10 @@ reference to the image. When the last Python reference to the image object is
 deleted, the image data is deleted as well, and Tk will display an empty box
 wherever the image was used.

+.. seealso::
+
+    The `Pillow package <http://python-pillow.org/>`_ adds support for


The note above (Doc/distutils/introduction.rst) tells about misleading of calling it a package.

If I understand correctly, the note above is detailing Distutils-specific terminology. If you go up a little, the definition of "package" in the General Python terminology section accurately describes Pillow.

serhiy-storchaka · 2018-04-18T18:30:34Z

I think updating references to PIL-style arrays should be done in a separate issue. It can require the help of corresponding experts.

andresdelfino · 2018-04-18T18:47:04Z

@serhiy-storchaka regarding the PIL.Image reference in Doc/faq/programming.rst: Pillow preserves PIL naming for backwards compatibility.

What does fail after installing Pillow is import pillow :)

andresdelfino · 2018-04-18T18:47:59Z

I agree with @serhiy-storchaka regarding PIL-style arrays references.

serhiy-storchaka · 2018-04-18T18:56:15Z

Ah, I see that the name of the module is still PIL.Image in Pillow. Okay.

serhiy-storchaka · 2018-04-20T12:07:20Z

Doc/distutils/introduction.rst

-   module distributions are NumPy, SciPy, PIL (the Python Imaging
-   Library), or mxBase.  (This would be called a *package*, except that term is
+   module distributions are NumPy, SciPy, Pillow
+   , or mxBase.  (This would be called a *package*, except that term is


Remove whitespaces before comma.

Wouldn't that make reStructuredText separate the "module distributions..." line from the preceding paragraph?

I have updated the PR, could you check if it is addressing your comment?

serhiy-storchaka · 2018-04-21T12:16:30Z

Thanks!

bedevere-bot · 2018-04-21T12:17:28Z

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

miss-islington · 2018-04-21T12:17:28Z

Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

bedevere-bot · 2018-04-21T12:17:47Z

GH-6560 is a backport of this pull request to the 3.7 branch.

…6505) Also update PIL doc references to Pillow. (cherry picked from commit b81ca28) Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>

bedevere-bot · 2018-04-21T12:18:36Z

GH-6561 is a backport of this pull request to the 3.6 branch.

miss-islington · 2018-04-21T12:19:32Z

Sorry, @andresdelfino and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b81ca28b378c8b29204a37f8bd433a3379f53f7d 2.7

Also update PIL doc references to Pillow. (cherry picked from commit b81ca28) Co-authored-by: Andrés Delfino <34587441+andresdelfino@users.noreply.github.com>

andresdelfino · 2018-04-21T13:04:24Z

I'm cherry picking the commit for 2,7.

bedevere-bot · 2018-04-21T14:06:40Z

GH-6562 is a backport of this pull request to the 2.7 branch.

…6505) (GH-6562) Also update PIL doc references to Pillow. (cherry picked from commit 'b81ca28b378c8b29204a37f8bd433a3379f53f7d') Co-authored-by: 'Andrés Delfino.34587441+andresdelfino@users.noreply.github.com'

Mention Pillow to work with more image formats

92ca814

the-knights-who-say-ni added the CLA signed label Apr 17, 2018

bedevere-bot added the awaiting review label Apr 17, 2018

ambv requested a review from terryjreedy April 17, 2018 21:41

terryjreedy requested a review from serhiy-storchaka April 17, 2018 22:12

serhiy-storchaka added needs backport to 3.6 docs Documentation in the Doc dir skip news labels Apr 18, 2018

serhiy-storchaka reviewed Apr 18, 2018

View reviewed changes

andresdelfino added 2 commits April 18, 2018 07:50

Update PIL doc references to Pillow

ca639c2

Update Pillow URL

497747c

serhiy-storchaka reviewed Apr 18, 2018

View reviewed changes

andresdelfino added 3 commits April 18, 2018 16:27

Change link from Pillow package to just Pillow

933dcd3

Unwrap lines

368160b

Unwrap line

325fa21

serhiy-storchaka reviewed Apr 20, 2018

View reviewed changes

Remove whitespace before comma

0b826c9

serhiy-storchaka approved these changes Apr 21, 2018

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Apr 21, 2018

serhiy-storchaka merged commit b81ca28 into python:master Apr 21, 2018

bedevere-bot removed the awaiting merge label Apr 21, 2018

bedevere-bot removed the needs backport to 3.7 label Apr 21, 2018

bedevere-bot removed the needs backport to 3.6 label Apr 21, 2018

bedevere-bot removed the needs backport to 2.7 label Apr 21, 2018

andresdelfino deleted the mention_pillow branch April 21, 2018 14:09

terryjreedy removed their request for review May 16, 2018 02:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-33297: Mention Pillow to work with more image formats #6505

bpo-33297: Mention Pillow to work with more image formats #6505

andresdelfino commented Apr 17, 2018 •

edited by bedevere-bot

Loading

terryjreedy commented Apr 17, 2018

serhiy-storchaka Apr 18, 2018

andresdelfino Apr 18, 2018

andresdelfino Apr 18, 2018

andresdelfino Apr 18, 2018

serhiy-storchaka Apr 18, 2018 •

edited

Loading

andresdelfino Apr 18, 2018

andresdelfino Apr 18, 2018

serhiy-storchaka commented Apr 18, 2018

andresdelfino commented Apr 18, 2018

serhiy-storchaka left a comment

serhiy-storchaka Apr 18, 2018

andresdelfino Apr 18, 2018

andresdelfino Apr 18, 2018

serhiy-storchaka Apr 19, 2018

andresdelfino Apr 20, 2018

serhiy-storchaka Apr 18, 2018

andresdelfino Apr 18, 2018

serhiy-storchaka Apr 18, 2018

serhiy-storchaka commented Apr 18, 2018

andresdelfino commented Apr 18, 2018

andresdelfino commented Apr 18, 2018

serhiy-storchaka commented Apr 18, 2018

serhiy-storchaka Apr 20, 2018

andresdelfino Apr 20, 2018

andresdelfino Apr 21, 2018

serhiy-storchaka commented Apr 21, 2018

bedevere-bot commented Apr 21, 2018

miss-islington commented Apr 21, 2018

bedevere-bot commented Apr 21, 2018

bedevere-bot commented Apr 21, 2018

miss-islington commented Apr 21, 2018

andresdelfino commented Apr 21, 2018

bedevere-bot commented Apr 21, 2018

bpo-33297: Mention Pillow to work with more image formats #6505

bpo-33297: Mention Pillow to work with more image formats #6505

Conversation

andresdelfino commented Apr 17, 2018 • edited by bedevere-bot Loading

terryjreedy commented Apr 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serhiy-storchaka Apr 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serhiy-storchaka commented Apr 18, 2018

andresdelfino commented Apr 18, 2018

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serhiy-storchaka commented Apr 18, 2018

andresdelfino commented Apr 18, 2018

andresdelfino commented Apr 18, 2018

serhiy-storchaka commented Apr 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serhiy-storchaka commented Apr 21, 2018

bedevere-bot commented Apr 21, 2018

miss-islington commented Apr 21, 2018

bedevere-bot commented Apr 21, 2018

bedevere-bot commented Apr 21, 2018

miss-islington commented Apr 21, 2018

andresdelfino commented Apr 21, 2018

bedevere-bot commented Apr 21, 2018

andresdelfino commented Apr 17, 2018 •

edited by bedevere-bot

Loading

serhiy-storchaka Apr 18, 2018 •

edited

Loading