Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Update Function Annotations Doc with correct PEP #6304

Merged
merged 1 commit into from
Apr 25, 2018
Merged

[master] Update Function Annotations Doc with correct PEP #6304

merged 1 commit into from
Apr 25, 2018

Conversation

neerajbadlani
Copy link
Contributor

Added PEP 3107 to Funtions Annotations Documentation
in tutorial/controlflow.rst

@neerajbadlani
Update Function Annotations Doc with correct PEP
56998dc 
Added PEP 3107 to Funtions Annotations Documentation
in tutorial/controlflow.rst
@neerajbadlani neerajbadlani changed the title Update Function Annotations Doc with correct PEP [master] Update Function Annotations Doc with correct PEP Mar 29, 2018
zware
zware approved these changes Apr 25, 2018
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That sectionauthor line should probably be removed :)

@zware zware merged commit 643ff71 into python:master Apr 25, 2018
@zware
Copy link
Member

zware commented Apr 25, 2018

Thanks, @neerajbadlani!

@miss-islington
Copy link
Contributor

Thanks @neerajbadlani for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @neerajbadlani for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 25, 2018
@neerajbadlani @miss-islington
Mention both relevant PEPs in function annotations tutorial (pythonGH…
a96551c 
…-6304)

Patch by Neeraj Badlani.
(cherry picked from commit 643ff71)

Co-authored-by: Neeraj Badlani <neerajbadlani@gmail.com>
@bedevere-bot
Copy link

GH-6598 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 25, 2018
@neerajbadlani @miss-islington
Mention both relevant PEPs in function annotations tutorial (pythonGH…
d1ce73d 
…-6304)

Patch by Neeraj Badlani.
(cherry picked from commit 643ff71)

Co-authored-by: Neeraj Badlani <neerajbadlani@gmail.com>
@bedevere-bot
Copy link

GH-6599 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Apr 25, 2018
@miss-islington @neerajbadlani
Mention both relevant PEPs in function annotations tutorial (GH-6304)
0d19fa9 
Patch by Neeraj Badlani.
(cherry picked from commit 643ff71)

Co-authored-by: Neeraj Badlani <neerajbadlani@gmail.com>
miss-islington added a commit that referenced this pull request Apr 25, 2018
@miss-islington @neerajbadlani
Mention both relevant PEPs in function annotations tutorial (GH-6304)
1985849 
Patch by Neeraj Badlani.
(cherry picked from commit 643ff71)

Co-authored-by: Neeraj Badlani <neerajbadlani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@zware zware zware approved these changes

Assignees

@zware zware

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@neerajbadlani @zware @miss-islington @bedevere-bot @eric-wieser @serhiy-storchaka @the-knights-who-say-ni