bpo-33141: Have dataclasses.Field pass through __set_name__ to any default descriptor. #6260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xists. This allows the descriptor protocol's __set_name__ to work.
|
This is part of PEP 487 and the descriptor protocol. |
|
Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-6261 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 26, 2018
…fault argument. (pythonGH-6260) This is part of PEP 487 and the descriptor protocol. (cherry picked from commit de7a2f0) Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
| # the default value, so the end result is a descriptor that had | ||
| # __set_name__ called on it at the right time. | ||
| def __set_name__(self, owner, name): | ||
| func = getattr(self.default, '__set_name__', None) |
There was a problem hiding this comment.
I got here late, but shouldn't this check for __set_name__ on type(self.default) instead? That's how dunder protocols usually work, and it's also how typeobject.c itself implements __set_name__ (using _PyObject_LookupSpecial).
There was a problem hiding this comment.
Good catch, thanks. I've created https://bugs.python.org/issue33175.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33141