FIX documentation and NEWS of ThreadedHTTPServer. #6207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned-deily
approved these changes
Mar 24, 2018
vadmium
reviewed
Mar 25, 2018
Doc/library/http.server.rst
Outdated
| @@ -37,9 +37,12 @@ handler. Code to create and run the server looks like this:: | |||
|
|
|||
| This class is identical to HTTPServer but uses threads to handle | |||
| requests by using the :class:`~socketserver.ThreadingMixin`. This | |||
| is usefull to handle web browsers pre-opening sockets, on which | |||
| is useful to handle web browsers pre-opening sockets, on which | |||
| :class:`HTTPServer` would wait indefinitly. | |||
There was a problem hiding this comment.
Needs a second E: indefinitely (I think this was also your wording :)
|
Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 28, 2018
(cherry picked from commit 79c3bab) Co-authored-by: Julien Palard <julien@palard.fr>
|
GH-6302 is a backport of this pull request to the 3.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments from #6203.