Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30953: Improve error messages and add tests for jumping #6196

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 23, 2018

into/out of an except block.

https://bugs.python.org/issue30953

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement tests Tests in the Lib/test dir skip news labels Mar 23, 2018
try:
output.append(2)
output.append(3)
except: # still executed if the jump is failed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'still' in the comment is a little bit misleading, the except clause is executed because the jump is failed otherwise it would not be executed.

Copy link
Contributor

@xdegaye xdegaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit 397466d into python:master Mar 23, 2018
@serhiy-storchaka serhiy-storchaka deleted the jump-except-block branch March 23, 2018 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants