bpo-32941: Add madvise() for mmap objects #6172

ZackerySpytz · 2018-03-21T03:11:57Z

Allow mmap objects to access the madvise() system call.

https://bugs.python.org/issue32941

Allow mmap objects to access the madvise() system call.

Modules/mmapmodule.c

Doc/library/mmap.rst

pitrou

Thanks for doing this! I left a couple comments that need to be addressed.

bedevere-bot · 2018-03-22T12:27:13Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

mhvk · 2019-03-22T19:52:51Z

Over at numpy/numpy#13172, it became clear that having this would be very useful for ~numpy.memmap (which wraps a mmap as an array). @ZackerySpytz - will you be able to implement requested changes? If not, I'll note in the numpy issue that it would be good for someone to take it over; it seems fairly straightforward.

pitrou · 2019-03-22T19:57:54Z

Might also be useful for multiprocessing. @applio

…dvise

Modules/mmapmodule.c

Doc/library/mmap.rst

ZackerySpytz · 2019-03-27T07:48:35Z

I will make the requested changes.

@pitrou, thank you for the review, and I'm sorry for the enormous delay.

…dvise

Allow lengths greater than self->size. Add docs for MADV_* Constants.

ZackerySpytz · 2019-05-15T07:52:08Z

I have made the requested changes; please review again.

I have also added a sentence to the docs explaining that start must be a multiple of the PAGESIZE.

bedevere-bot · 2019-05-15T07:52:13Z

Thanks for making the requested changes!

@pitrou: please review the changes made to this pull request.

pitrou

Thank you! A few nits below, otherwise the PR looks good to me.

Modules/mmapmodule.c

pitrou · 2019-05-22T21:06:19Z

Modules/mmapmodule.c

+        return NULL;
+    }
+    if (length <= 0) {
+        PyErr_SetString(PyExc_ValueError, "madvise length invalid");


Here as well: perhaps "madvise length must be > 0"?

By the way, Linux madvise() allows length to be 0 (according to its manpage).

Well, I'm not sure why one would pass a length of zero. I think it's okay to change the check to length < 0, though.

Modules/mmapmodule.c

bedevere-bot · 2019-05-22T21:10:15Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

pitrou · 2019-05-22T21:10:54Z

(also, please ensure you rebase or merge from master and fix conflicts)

…dvise

Allow a length of 0.

ZackerySpytz · 2019-05-24T12:12:00Z

Thanks, @pitrou.

I have made the requested changes; please review again.

bedevere-bot · 2019-05-24T12:12:04Z

Thanks for making the requested changes!

@pitrou: please review the changes made to this pull request.

ZackerySpytz · 2019-05-27T16:21:04Z

@pitrou Ping. I would like to get this merged.

pitrou · 2019-05-27T16:24:32Z

Yes, I'm taking a final look this evening.

pitrou · 2019-05-27T16:48:45Z

Thank you @ZackerySpytz :-)

bedevere-bot · 2019-05-27T17:16:21Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64 Fedora 3.x has failed when building commit 02db696.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/53/builds/3027) and take a look at the build logs.
Check if the failure is related to this commit (02db696) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/53/builds/3027

Click to see traceback logs

From https://github.com/python/cpython
 * branch            master     -> FETCH_HEAD
Reset branch 'master'

Objects/obmalloc.c:1376:1: warning: ‘no_sanitize_thread’ attribute directive ignored [-Wattributes]
 {
 ^

test_devpoll skipped -- test works only on Solaris OS family
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_kqueue skipped -- test works only on BSD
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_winreg skipped -- No module named 'winreg'
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '//psm_874f9b9b': [Errno 2] No such file or directory: '//psm_874f9b9b'
  warnings.warn('resource_tracker: %r: %s' % (name, e))
test_winsound skipped -- No module named 'winsound'
test_msilib skipped -- No module named '_msi'
test_startfile skipped -- object <module 'os' from '/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64/build/Lib/os.py'> has no attribute 'startfile'
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_around_2GB (test.test_mmap.LargeMmapTests) ... ok
test_around_4GB (test.test_mmap.LargeMmapTests) ... ok
test_large_filesize (test.test_mmap.LargeMmapTests) ... ok
test_large_offset (test.test_mmap.LargeMmapTests) ... ok
test_access_parameter (test.test_mmap.MmapTests) ... ok
test_anonymous (test.test_mmap.MmapTests) ... ok
test_bad_file_desc (test.test_mmap.MmapTests) ... ok
test_basic (test.test_mmap.MmapTests) ... ok
test_concat_repeat_exception (test.test_mmap.MmapTests) ... ok
test_context_manager (test.test_mmap.MmapTests) ... ok
test_context_manager_exception (test.test_mmap.MmapTests) ... ok
test_crasher_on_windows (test.test_mmap.MmapTests) ... skipped 'requires Windows'
test_double_close (test.test_mmap.MmapTests) ... ok
test_empty_file (test.test_mmap.MmapTests) ... ok
test_entire_file (test.test_mmap.MmapTests) ... ok
test_error (test.test_mmap.MmapTests) ... ok
test_extended_getslice (test.test_mmap.MmapTests) ... ok
test_extended_set_del_slice (test.test_mmap.MmapTests) ... ok
test_find_end (test.test_mmap.MmapTests) ... ok
test_flush_return_value (test.test_mmap.MmapTests) ... ok
test_invalid_descriptor (test.test_mmap.MmapTests) ... skipped 'requires Windows'
test_io_methods (test.test_mmap.MmapTests) ... ok
test_length_0_large_offset (test.test_mmap.MmapTests) ... ok
test_length_0_offset (test.test_mmap.MmapTests) ... ok
test_madvise (test.test_mmap.MmapTests) ... ERROR
test_move (test.test_mmap.MmapTests) ... ok
test_non_ascii_byte (test.test_mmap.MmapTests) ... ok
test_offset (test.test_mmap.MmapTests) ... ok
test_prot_readonly (test.test_mmap.MmapTests) ... ok
test_read_all (test.test_mmap.MmapTests) ... ok
test_read_invalid_arg (test.test_mmap.MmapTests) ... ok
test_resize_past_pos (test.test_mmap.MmapTests) ... ok
test_rfind (test.test_mmap.MmapTests) ... ok
test_sizeof (test.test_mmap.MmapTests) ... skipped 'requires Windows'
test_subclass (test.test_mmap.MmapTests) ... ok
test_tagname (test.test_mmap.MmapTests) ... skipped 'requires Windows'
test_tougher_find (test.test_mmap.MmapTests) ... ok
test_weakref (test.test_mmap.MmapTests) ... ok
test_write_returning_the_number_of_bytes_written (test.test_mmap.MmapTests) ... ok

======================================================================
ERROR: test_madvise (test.test_mmap.MmapTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64/build/Lib/test/test_mmap.py", line 754, in test_madvise
    m.madvise(mmap.MADV_NORMAL, PAGESIZE, sys.maxsize)
ValueError: madvise start out of bounds

----------------------------------------------------------------------

Ran 39 tests in 0.802s

FAILED (errors=1, skipped=4)
test test_mmap failed
stty: standard input: Inappropriate ioctl for device
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_winconsoleio skipped -- test only relevant on win32
test_ioctl skipped -- Unable to open /dev/tty
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 6.757s

OK (skipped=2)
test test_mmap failed
make: *** [buildbottest] Error 2

bedevere-bot · 2019-05-27T17:17:47Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE Fedora 3.x has failed when building commit 02db696.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/85/builds/2848) and take a look at the build logs.
Check if the failure is related to this commit (02db696) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/85/builds/2848

Click to see traceback logs

From https://github.com/python/cpython
 * branch            master     -> FETCH_HEAD
Reset branch 'master'

Objects/obmalloc.c:1376:1: warning: ‘no_sanitize_thread’ attribute directive ignored [-Wattributes]
 {
 ^

test_winreg skipped -- No module named 'winreg'
test_devpoll skipped -- test works only on Solaris OS family
test_msilib skipped -- No module named '_msi'
test_ossaudiodev skipped -- [Errno 2] No such file or directory: '/dev/dsp'
test_ioctl skipped -- Unable to open /dev/tty
/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '//psm_101838b4': [Errno 2] No such file or directory: '//psm_101838b4'
  warnings.warn('resource_tracker: %r: %s' % (name, e))
stty: standard input: Inappropriate ioctl for device
/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '//psm_cb70aca7': [Errno 2] No such file or directory: '//psm_cb70aca7'
  warnings.warn('resource_tracker: %r: %s' % (name, e))
test_kqueue skipped -- test works only on BSD
/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/multiprocessing/resource_tracker.py:203: UserWarning: resource_tracker: There appear to be 1 leaked shared_memory objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: '//psm_ea9bd3e2': [Errno 2] No such file or directory: '//psm_ea9bd3e2'
  warnings.warn('resource_tracker: %r: %s' % (name, e))
test_around_2GB (test.test_mmap.LargeMmapTests) ... ok
test_around_4GB (test.test_mmap.LargeMmapTests) ... ok
test_large_filesize (test.test_mmap.LargeMmapTests) ... ok
test_large_offset (test.test_mmap.LargeMmapTests) ... ok
test_access_parameter (test.test_mmap.MmapTests) ... ok
test_anonymous (test.test_mmap.MmapTests) ... ok
test_bad_file_desc (test.test_mmap.MmapTests) ... ok
test_basic (test.test_mmap.MmapTests) ... ok
test_concat_repeat_exception (test.test_mmap.MmapTests) ... ok
test_context_manager (test.test_mmap.MmapTests) ... ok
test_context_manager_exception (test.test_mmap.MmapTests) ... ok
test_crasher_on_windows (test.test_mmap.MmapTests) ... skipped 'requires Windows'
test_double_close (test.test_mmap.MmapTests) ... ok
test_empty_file (test.test_mmap.MmapTests) ... ok
test_entire_file (test.test_mmap.MmapTests) ... ok
test_error (test.test_mmap.MmapTests) ... ok
test_extended_getslice (test.test_mmap.MmapTests) ... ok
test_extended_set_del_slice (test.test_mmap.MmapTests) ... ok
test_find_end (test.test_mmap.MmapTests) ... ok
test_flush_return_value (test.test_mmap.MmapTests) ... ok
test_invalid_descriptor (test.test_mmap.MmapTests) ... skipped 'requires Windows'
test_io_methods (test.test_mmap.MmapTests) ... ok
test_length_0_large_offset (test.test_mmap.MmapTests) ... ok
test_length_0_offset (test.test_mmap.MmapTests) ... ok
test_madvise (test.test_mmap.MmapTests) ... ERROR
test_move (test.test_mmap.MmapTests) ... ok
test_non_ascii_byte (test.test_mmap.MmapTests) ... ok
test_offset (test.test_mmap.MmapTests) ... ok
test_prot_readonly (test.test_mmap.MmapTests) ... ok
test_read_all (test.test_mmap.MmapTests) ... ok
test_read_invalid_arg (test.test_mmap.MmapTests) ... ok
test_resize_past_pos (test.test_mmap.MmapTests) ... ok
test_rfind (test.test_mmap.MmapTests) ... ok
test_sizeof (test.test_mmap.MmapTests) ... skipped 'requires Windows'
test_subclass (test.test_mmap.MmapTests) ... ok
test_tagname (test.test_mmap.MmapTests) ... skipped 'requires Windows'
test_tougher_find (test.test_mmap.MmapTests) ... ok
test_weakref (test.test_mmap.MmapTests) ... ok
test_write_returning_the_number_of_bytes_written (test.test_mmap.MmapTests) ... ok

======================================================================
ERROR: test_madvise (test.test_mmap.MmapTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_mmap.py", line 754, in test_madvise
    m.madvise(mmap.MADV_NORMAL, PAGESIZE, sys.maxsize)
ValueError: madvise start out of bounds

----------------------------------------------------------------------

Ran 39 tests in 1.052s

FAILED (errors=1, skipped=4)
test test_mmap failed
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_startfile skipped -- object <module 'os' from '/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/os.py'> has no attribute 'startfile'
test_winsound skipped -- No module named 'winsound'
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 7.082s

OK (skipped=2)
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_winconsoleio skipped -- test only relevant on win32
test test_mmap failed
make: *** [buildbottest] Error 2

pitrou · 2019-05-27T17:22:15Z

Interesting. It seems PPC64 has a 64kB page size.

@vstinner What is the procedure to test a quick fix on a buildbot without going through Github? Edit: I found the answer.

pitrou · 2019-05-27T17:38:03Z

Fix at #13596

Allow mmap objects to access the madvise() system call.

bpo-32941: Add madvise() for mmap objects

80f12a3

Allow mmap objects to access the madvise() system call.

the-knights-who-say-ni added the CLA signed label Mar 21, 2018

bedevere-bot added the awaiting review label Mar 21, 2018

pitrou reviewed Mar 22, 2018

View reviewed changes

Modules/mmapmodule.c Outdated Show resolved Hide resolved

pitrou reviewed Mar 22, 2018

View reviewed changes

Modules/mmapmodule.c Show resolved Hide resolved

pitrou reviewed Mar 22, 2018

View reviewed changes

Modules/mmapmodule.c Outdated Show resolved Hide resolved

pitrou reviewed Mar 22, 2018

View reviewed changes

Doc/library/mmap.rst Show resolved Hide resolved

pitrou requested changes Mar 22, 2018

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Mar 22, 2018

Merge branch 'master' into bpo-32941-mmap-madvise

9d99228

seberg mentioned this pull request Mar 22, 2019

ENH: Add madvise for memmap objects numpy/numpy#13172

Open

Merge remote-tracking branch 'upstream/master' into bpo-32941-mmap-ma…

9ce2db8

…dvise

vadmium reviewed Mar 23, 2019

View reviewed changes

Modules/mmapmodule.c Outdated Show resolved Hide resolved

Doc/library/mmap.rst Outdated Show resolved Hide resolved

a-deeb mentioned this pull request Mar 25, 2019

ENH: Added mmapmodule.c to Allow mmap objects to access the madvise() system call numpy/numpy#13184

Closed

ZackerySpytz added 2 commits May 14, 2019 17:20

Merge remote-tracking branch 'upstream/master' into bpo-32941-mmap-ma…

5fe99a4

…dvise

Address the review comments.

b6d9c48

Allow lengths greater than self->size. Add docs for MADV_* Constants.

bedevere-bot added awaiting change review and removed awaiting changes labels May 15, 2019

pitrou requested changes May 22, 2019

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting change review labels May 22, 2019

ZackerySpytz added 2 commits May 24, 2019 05:52

Merge remote-tracking branch 'upstream/master' into bpo-32941-mmap-ma…

11496fc

…dvise

Tweak some error messages.

4aff06d

Allow a length of 0.

bedevere-bot added awaiting change review and removed awaiting changes labels May 24, 2019

pitrou approved these changes May 27, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 27, 2019

pitrou merged commit 02db696 into python:master May 27, 2019

bedevere-bot removed the awaiting merge label May 27, 2019

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020

bpo-32941: Add madvise() for mmap objects (pythonGH-6172)

d5c9c4c

Allow mmap objects to access the madvise() system call.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-32941: Add madvise() for mmap objects #6172

bpo-32941: Add madvise() for mmap objects #6172

ZackerySpytz commented Mar 21, 2018 •

edited by bedevere-bot

Loading

pitrou left a comment

bedevere-bot commented Mar 22, 2018

mhvk commented Mar 22, 2019

pitrou commented Mar 22, 2019

ZackerySpytz commented Mar 27, 2019

ZackerySpytz commented May 15, 2019

bedevere-bot commented May 15, 2019

pitrou left a comment

pitrou May 22, 2019

pitrou May 22, 2019

ZackerySpytz May 24, 2019

bedevere-bot commented May 22, 2019

pitrou commented May 22, 2019

ZackerySpytz commented May 24, 2019

bedevere-bot commented May 24, 2019

ZackerySpytz commented May 27, 2019

pitrou commented May 27, 2019

pitrou commented May 27, 2019

bedevere-bot commented May 27, 2019

bedevere-bot commented May 27, 2019

pitrou commented May 27, 2019 •

edited

Loading

pitrou commented May 27, 2019

bpo-32941: Add madvise() for mmap objects #6172

bpo-32941: Add madvise() for mmap objects #6172

Conversation

ZackerySpytz commented Mar 21, 2018 • edited by bedevere-bot Loading

pitrou left a comment

Choose a reason for hiding this comment

bedevere-bot commented Mar 22, 2018

mhvk commented Mar 22, 2019

pitrou commented Mar 22, 2019

ZackerySpytz commented Mar 27, 2019

ZackerySpytz commented May 15, 2019

bedevere-bot commented May 15, 2019

pitrou left a comment

Choose a reason for hiding this comment

pitrou May 22, 2019

Choose a reason for hiding this comment

pitrou May 22, 2019

Choose a reason for hiding this comment

ZackerySpytz May 24, 2019

Choose a reason for hiding this comment

bedevere-bot commented May 22, 2019

pitrou commented May 22, 2019

ZackerySpytz commented May 24, 2019

bedevere-bot commented May 24, 2019

ZackerySpytz commented May 27, 2019

pitrou commented May 27, 2019

pitrou commented May 27, 2019

bedevere-bot commented May 27, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented May 27, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

pitrou commented May 27, 2019 • edited Loading

pitrou commented May 27, 2019

ZackerySpytz commented Mar 21, 2018 •

edited by bedevere-bot

Loading

pitrou commented May 27, 2019 •

edited

Loading