bpo-33042: Fix pre-initialization sys module configuration #6157
Conversation
- new embedding test case for bpo-33042 - also enhances existing embedding test cases to check for expected settings in the sys module
ncoghlan
force-pushed
the
bpo-33042-restore-preinit-sys-options
branch
from
c415c07 to
1354cef
Compare
- adds checks for a valid thread state - notes the intended handling of supplied values - test case no longer segfaults, but fails due to the values not being added to the sys module
…reinit-sys-options
|
@vstinner @serhiy-storchaka This is lower level C than I've done in quite a while, so it would be nice if one or both of you could take a look at it :) Serhiy, a bit of extra context here is that the new code all needs to run before |
|
Also see https://bugs.python.org/issue33042#msg314366 for a potential problem where I suspect the warnings filter list may not yet be getting updated appropriately. |
|
@zooba @brettcannon @ericsnowcurrently I'm attempting to fix an app embedding regression that's affecting PyInstaller, but I'm getting a failure that I don't understand for the new test case on Windows. Any chance that one of you might be able to take a look in time for 3.7.0b3? |
ncoghlan
changed the title
|
While I'd have preferred to wait for a review, there's a conflict between that and getting this merged in time for 3.7.0b3, so I'm going to go ahead and merge it. Reviews still welcome, I'll just need to fix any issues found in a follow-up PR. |
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
…6157) - new test case for pre-initialization of sys.warnoptions and sys._xoptions - restored ability to call these APIs prior to Py_Initialize - updated the docs for the affected APIs to make it clear they can be called before Py_Initialize - also enhanced the existing embedding test cases to check for expected settings in the sys module (cherry picked from commit bc77eff) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
|
GH-6232 is a backport of this pull request to the 3.7 branch. |
- new test case for pre-initialization of sys.warnoptions and sys._xoptions - restored ability to call these APIs prior to Py_Initialize - updated the docs for the affected APIs to make it clear they can be called before Py_Initialize - also enhanced the existing embedding test cases to check for expected settings in the sys module (cherry picked from commit bc77eff) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
called before Py_Initialize
to check for expected settings in the sys module
https://bugs.python.org/issue33042