Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-27428: Fix WindowsRegistryFinder documentation #6061

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

Himanshu-Lakhara
Copy link
Contributor

@Himanshu-Lakhara Himanshu-Lakhara commented Mar 10, 2018

Update documentation to clarify WindowsRegistryFinder
implement MetaPathFinder

https://bugs.python.org/issue27428

Update documentation to clarify that WindowsRegistryFinder
implement MetaPathFinder
@brettcannon brettcannon self-assigned this Mar 10, 2018
@brettcannon brettcannon added needs backport to 3.6 docs Documentation in the Doc dir labels Mar 10, 2018
@brettcannon
Copy link
Member

Thanks for the patch, @Himanshu-Lakhara ! I'll try to review this sometime in the next week or two.

@Himanshu-Lakhara
Copy link
Contributor Author

Thanks for reviewing @brettcannon and Sorry for delayed response. Since this is my first cpython PR and first PR on GitHub so I request you to please be thorough. I have previous experience contributing to open source project but not on GitHub. So It is possible that I might have missed something.

Thanks again for your time. I'll try to be more responsive.

@brettcannon
Copy link
Member

@Himanshu-Lakhara no worries. I've been very busy as of late so I have not gotten around to doing a review anyway (although I cursory look seems good 😃 ).

@brettcannon
Copy link
Member

I tweaked the news entry, but otherwise LGTM! Once CI passes again I will merge this.

@brettcannon brettcannon merged commit 5cbb841 into python:master Mar 23, 2018
@miss-islington
Copy link
Contributor

Thanks @Himanshu-Lakhara for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-6205 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2018
…e ABC (pythonGH-6061)

(cherry picked from commit 5cbb841)

Co-authored-by: Himanshu Lakhara <himanshulakhara1947@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2018
…e ABC (pythonGH-6061)

(cherry picked from commit 5cbb841)

Co-authored-by: Himanshu Lakhara <himanshulakhara1947@gmail.com>
@bedevere-bot
Copy link

GH-6206 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Mar 23, 2018
…e ABC (GH-6061)

(cherry picked from commit 5cbb841)

Co-authored-by: Himanshu Lakhara <himanshulakhara1947@gmail.com>
miss-islington added a commit that referenced this pull request Mar 23, 2018
…e ABC (GH-6061)

(cherry picked from commit 5cbb841)

Co-authored-by: Himanshu Lakhara <himanshulakhara1947@gmail.com>
@Himanshu-Lakhara Himanshu-Lakhara deleted the fix-issue-27428 branch March 24, 2018 04:38
@Himanshu-Lakhara
Copy link
Contributor Author

Thanks @brettcannon for merging and tweaking news entry. It was my first PR to cpython and first PR on GitHub. Learned cpython workflow and Feeling more confident to take up some coding task.

Thanks again for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants