Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33041: Add missed error checks when compile "async for" #6053

Merged
merged 1 commit into from
Mar 10, 2018
Merged

bpo-33041: Add missed error checks when compile "async for" #6053

merged 1 commit into from
Mar 10, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 10, 2018 •
edited by bedevere-bot
Loading

and remove redundant code.

https://bugs.python.org/issue33041

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 skip news labels Mar 10, 2018
@serhiy-storchaka serhiy-storchaka merged commit 67ee077 into python:master Mar 10, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

@serhiy-storchaka serhiy-storchaka deleted the async-for4 branch March 10, 2018 16:49
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 67ee07795bcd84b679c000780212d4d81a1490a3 3.7

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 67ee07795bcd84b679c000780212d4d81a1490a3 3.6

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 10, 2018
@serhiy-storchaka
[3.7] bpo-33041: Add missed error checks when compile "async for" (py…
938f950 
…thonGH-6053)

and remove redundant code.
(cherry picked from commit 67ee077)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-6060 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request Mar 10, 2018
@serhiy-storchaka
[3.7] bpo-33041: Add missed error checks when compile "async for" (GH…
9e94c0d 
…-6053) (GH-6060)

and remove redundant code.
(cherry picked from commit 67ee077)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2018
@serhiy-storchaka @miss-islington
[3.7] bpo-33041: Add missed error checks when compile "async for" (py…
ffb01cb 
…thonGH-6053) (pythonGH-6060)

and remove redundant code.
(cherry picked from commit 67ee077)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit 9e94c0d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Mar 10, 2018
@miss-islington @serhiy-storchaka
[3.7] bpo-33041: Add missed error checks when compile "async for" (GH…
d082634 
…-6053) (GH-6060)

and remove redundant code.
(cherry picked from commit 67ee077)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit 9e94c0d)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@serhiy-storchaka @jo2y
bpo-33041: Add missed error checks when compile "async for" (python#6053
d90a07a 
)

and remove redundant code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @1st1 @the-knights-who-say-ni