-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-32996: Improve What's New in 3.7. #5983
bpo-32996: Improve What's New in 3.7. #5983
Conversation
Doc/whatsnew/3.7.rst
Outdated
Function :func:`~zipapp.create_archive` now accepts an optional *compressed* | ||
argument to generate a compressed archive. A command line option | ||
``--compress`` has also been added to support compression. | ||
(Contributed by Xiang Zhang in :issue:`31638`.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not by me :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, seems I pasted wrong value.
Doc/whatsnew/3.7.rst
Outdated
@@ -473,7 +474,7 @@ cgi | |||
--- | |||
|
|||
:func:`~cgi.parse_multipart` returns the same results as | |||
:class:`~FieldStorage` : for non-file fields, the value associated to a key | |||
:class:`~FieldStorage` for non-file fields, the value associated to a key | |||
is a list of strings, not bytes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original makes more sense to me, and seems to be correct. I understand Pierre’s change always uses FieldStorage, regardless of whether a field represents a file or not. Otherwise you would need a new sentence or semicolon to start “The value associated . . .”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then the space before :
should be removed. And the whole entry should be moved to the "Porting to Python 3.7" section, since this is rather a compatibility-breaking change than a new feature.
Looks good. Keep in mind that @elprans and I will edit what's new (as we did for 3.5 & 3.6) closer to 3.7 release. |
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
@serhiy-storchaka: Please replace |
GH-6071 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 51302a5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
https://bugs.python.org/issue32996