Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32996: Improve What's New in 3.7. #5983

Merged
merged 4 commits into from
Mar 11, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 5, 2018

Function :func:`~zipapp.create_archive` now accepts an optional *compressed*
argument to generate a compressed archive. A command line option
``--compress`` has also been added to support compression.
(Contributed by Xiang Zhang in :issue:`31638`.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not by me :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, seems I pasted wrong value.

@@ -473,7 +474,7 @@ cgi
---

:func:`~cgi.parse_multipart` returns the same results as
:class:`~FieldStorage` : for non-file fields, the value associated to a key
:class:`~FieldStorage` for non-file fields, the value associated to a key
is a list of strings, not bytes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original makes more sense to me, and seems to be correct. I understand Pierre’s change always uses FieldStorage, regardless of whether a field represents a file or not. Otherwise you would need a new sentence or semicolon to start “The value associated . . .”.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the space before : should be removed. And the whole entry should be moved to the "Porting to Python 3.7" section, since this is rather a compatibility-breaking change than a new feature.

@1st1
Copy link
Member

1st1 commented Mar 6, 2018

Looks good. Keep in mind that @elprans and I will edit what's new (as we did for 3.5 & 3.6) closer to 3.7 release.

@serhiy-storchaka serhiy-storchaka merged commit 51302a5 into python:master Mar 11, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

@serhiy-storchaka serhiy-storchaka deleted the whatsnew-3.7 branch March 11, 2018 01:48
@bedevere-bot
Copy link

GH-6071 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2018
(cherry picked from commit 51302a5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Mar 11, 2018
(cherry picked from commit 51302a5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants