Skip to content

bpo-25427: Remove pyvenv #5962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Doc/installing/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,6 @@ Key terms
of the mailing list used to coordinate Python packaging standards
development).

.. deprecated:: 3.6
``pyvenv`` was the recommended tool for creating virtual environments for
Python 3.3 and 3.4, and is `deprecated in Python 3.6
<https://docs.python.org/dev/whatsnew/3.6.html#deprecated-features>`_.

.. versionchanged:: 3.5
The use of ``venv`` is now recommended for creating virtual environments.

Expand Down
4 changes: 0 additions & 4 deletions Doc/library/venv.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ independent set of installed Python packages in its site directories.

See :pep:`405` for more information about Python virtual environments.

.. note::
The ``pyvenv`` script has been deprecated as of Python 3.6 in favor of using
``python3 -m venv`` to help prevent any potential confusion as to which
Python interpreter a virtual environment will be based on.


Creating virtual environments
Expand Down
3 changes: 3 additions & 0 deletions Doc/whatsnew/3.8.rst
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ Deprecated
Removed
=======

* The ``pyvenv`` script has been removed in favor of ``python3.8 -m venv``
to help eliminate confusion as to what Python interpreter the ``pyvenv``
script is tied to. (Contributed by Brett Cannon in :issue:`25427`.)


Porting to Python 3.8
Expand Down
2 changes: 0 additions & 2 deletions Mac/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ installunixtools:
pydoc3 \
python3 \
python3-config \
pyvenv \
; \
do \
rm -f $${fn} ; \
Expand Down Expand Up @@ -118,7 +117,6 @@ altinstallunixtools:
pydoc$(VERSION) \
python$(VERSION) \
python$(LDVERSION)-config \
pyvenv-$(VERSION) \
; \
do \
rm -f $${fn} ;\
Expand Down
2 changes: 0 additions & 2 deletions Makefile.pre.in
Original file line number Diff line number Diff line change
Expand Up @@ -1216,8 +1216,6 @@ bininstall: altbininstall
(cd $(DESTDIR)$(BINDIR); $(LN) -s pydoc$(VERSION) pydoc3)
-rm -f $(DESTDIR)$(BINDIR)/2to3
(cd $(DESTDIR)$(BINDIR); $(LN) -s 2to3-$(VERSION) 2to3)
-rm -f $(DESTDIR)$(BINDIR)/pyvenv
(cd $(DESTDIR)$(BINDIR); $(LN) -s pyvenv-$(VERSION) pyvenv)
if test "x$(LIPO_32BIT_FLAGS)" != "x" ; then \
rm -f $(DESTDIR)$(BINDIR)/python3-32$(EXE); \
(cd $(DESTDIR)$(BINDIR); $(LN) -s python$(VERSION)-32$(EXE) python3-32$(EXE)) \
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Remove the pyvenv script in favor of ``python3 -m venv`` in order to lower
confusion as to what Python interpreter a virtual environment will be
created for.
3 changes: 0 additions & 3 deletions Tools/msi/tools/tools_files.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
<Component Id="Tools_scripts_pydoc3.py" Directory="Tools_scripts" Guid="*">
<File Id="Tools_scripts_pydoc3.py" Name="pydoc3.py" Source="!(bindpath.src)Tools\scripts\pydoc3" />
</Component>
<Component Id="Tools_scripts_pyvenv.py" Directory="Tools_scripts" Guid="*">
<File Id="Tools_scripts_pyvenv.py" Name="pyvenv.py" Source="!(bindpath.src)Tools\scripts\pyvenv" />
</Component>
</ComponentGroup>
</Fragment>
<Fragment>
Expand Down
17 changes: 0 additions & 17 deletions Tools/scripts/pyvenv

This file was deleted.

4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2291,7 +2291,7 @@ def copy_scripts(self):
newoutfiles = []
newupdated_files = []
for filename in outfiles:
if filename.endswith(('2to3', 'pyvenv')):
if filename.endswith('2to3'):
newfilename = filename + fullversion
else:
newfilename = filename + minoronly
Expand Down Expand Up @@ -2359,7 +2359,7 @@ def main():
# check the PyBuildScripts command above, and change the links
# created by the bininstall target in Makefile.pre.in
scripts = ["Tools/scripts/pydoc3", "Tools/scripts/idle3",
"Tools/scripts/2to3", "Tools/scripts/pyvenv"]
"Tools/scripts/2to3"]
)

# --install-platlib
Expand Down