Delete a broken threading.local example #5870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code never did anything correct or useful. The class attribute will never be affected, and the condition will never be true.
alex
added
needs backport to 3.6
docs
alex
approved these changes
Feb 25, 2018
Contributor
|
@alex: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2018
This code never did anything correct or useful. The class attribute will never be affected, and the condition will never be true. (cherry picked from commit 5fb632e) Co-authored-by: Aaron Gallagher <habnabit@users.noreply.github.com>
|
GH-5884 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2018
This code never did anything correct or useful. The class attribute will never be affected, and the condition will never be true. (cherry picked from commit 5fb632e) Co-authored-by: Aaron Gallagher <habnabit@users.noreply.github.com>
|
GH-5885 is a backport of this pull request to the 2.7 branch. |
|
GH-5886 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2018
This code never did anything correct or useful. The class attribute will never be affected, and the condition will never be true. (cherry picked from commit 5fb632e) Co-authored-by: Aaron Gallagher <habnabit@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Feb 25, 2018
This code never did anything correct or useful. The class attribute will never be affected, and the condition will never be true. (cherry picked from commit 5fb632e) Co-authored-by: Aaron Gallagher <habnabit@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Feb 25, 2018
This code never did anything correct or useful. The class attribute will never be affected, and the condition will never be true. (cherry picked from commit 5fb632e) Co-authored-by: Aaron Gallagher <habnabit@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Feb 25, 2018
This code never did anything correct or useful. The class attribute will never be affected, and the condition will never be true. (cherry picked from commit 5fb632e) Co-authored-by: Aaron Gallagher <habnabit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code never did anything correct or useful. The class attribute will never be affected, and the condition will never be true.
Requested by @alex.