bpo-29619: Convert st_ino using unsigned integer #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyangyu
approved these changes
Mar 8, 2017
serhiy-storchaka
requested changes
Mar 8, 2017
Modules/posixmodule.c
Outdated
| @@ -1927,11 +1927,13 @@ _pystat_fromstructstat(STRUCT_STAT *st) | |||
| return NULL; | |||
|
|
|||
| PyStructSequence_SET_ITEM(v, 0, PyLong_FromLong((long)st->st_mode)); | |||
| #ifdef HAVE_LARGEFILE_SUPPORT | |||
| #if defined(HAVE_LARGEFILE_SUPPORT) || defined(MS_WINDOWS) | |||
| assert(sizeof(st->st_ino) >= sizeof(unsigned long long)); | |||
There was a problem hiding this comment.
Use Py_BUILD_ASSERT.
Should test sizeof(st->st_ino) <= sizeof(unsigned long long).
There was a problem hiding this comment.
Ooops, I wrote my assertion backwards... Fixed, thanks!
Modules/posixmodule.c
Outdated
| @@ -11409,7 +11411,8 @@ os_DirEntry_inode_impl(DirEntry *self) | |||
| self->win32_file_index = stat.st_ino; | |||
| self->got_file_index = 1; | |||
| } | |||
| return PyLong_FromLongLong((long long)self->win32_file_index); | |||
| assert(sizeof(self->win32_file_index) >= sizeof(unsigned long long)); | |||
There was a problem hiding this comment.
sizeof(self->win32_file_index) <= sizeof(unsigned long long)
serhiy-storchaka
approved these changes
Mar 8, 2017
bpo-29619: os.stat() and os.DirEntry.inodeo() now convert inode (st_ino) using unsigned integers.
|
Ok, let's start with a backport to 3.6: #584 |
vstinner
added a commit
that referenced
this pull request
Mar 9, 2017
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Bumps [celery](https://github.com/celery/celery) from 5.2.6 to 5.2.7. - [Release notes](https://github.com/celery/celery/releases) - [Changelog](https://github.com/celery/celery/blob/master/Changelog.rst) - [Commits](celery/celery@v5.2.6...v5.2.7) --- updated-dependencies: - dependency-name: celery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-29619: os.stat() and os.DirEntry.inodeo() now convert inode
(st_ino) using unsigned integers.