Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32741: Implement TimerHandle.when() #5473

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Feb 1, 2018

The time is an absolute timestamp, using the same time
reference as :meth:`AbstractEventLoop.time`.

.. versionadded:: 3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..versionadded: 3.8 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @ned-deily decision

Copy link
Member

@matrixise matrixise Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asvetlov decision taken by @ned-deily ;-) welcome to 3.7 (If I have well read the message)

@asvetlov asvetlov merged commit 3d4dbd8 into python:master Feb 1, 2018
@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@asvetlov asvetlov deleted the timer-handle-when branch February 1, 2018 17:59
@bedevere-bot
Copy link

GH-5480 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2018
(cherry picked from commit 3d4dbd8)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Feb 1, 2018
(cherry picked from commit 3d4dbd8)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants