Document the error return of PyLong_As* APIs. #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A frequent Python C API error is neglecting to check the return value and PyErr_Occurred().
gpshead
added
needs backport to 3.6
docs
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
@gpshead: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 29, 2018
Document the error return of PyLong_As* APIs. A frequent Python C API usage error is neglecting to check the return value and/or PyErr_Occurred(). (cherry picked from commit f5b04a3)
|
GH-5404 is a backport of this pull request to the 3.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A frequent Python C API error is neglecting to check the return value
and call PyErr_Occurred().