Revert "bpo-32221: makeipaddr(): remove interface part [GH-4724] #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…honGH-4724)" This reverts commit 47c0b1f.
|
@1st1: Please replace |
ambv
pushed a commit
that referenced
this pull request
Aug 6, 2022
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 6, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com> (cherry picked from commit a17cd47) Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 6, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com> (cherry picked from commit a17cd47) Co-authored-by: Sion Kang <31057849+Yaminyam@users.noreply.github.com>
ambv
pushed a commit
that referenced
this pull request
Aug 6, 2022
ambv
pushed a commit
that referenced
this pull request
Aug 6, 2022
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 47c0b1f.
Two tests fail on Mac OS X:
======================================================================
ERROR: test_getaddrinfo_ipv6_scopeid (test.test_socket.GeneralModuleTests)
Traceback (most recent call last):
File "/Users/yury/dev/pydev/cpython/Lib/test/test_socket.py", line 1612, in test_getaddrinfo_ipv6_scopeid
ifindex = socket.if_nametoindex(test_interface)
OSError: no interface with this name
======================================================================
ERROR: test_getnameinfo_ipv6_scopeid (test.test_socket.GeneralModuleTests)
Traceback (most recent call last):
File "/Users/yury/dev/pydev/cpython/Lib/test/test_socket.py", line 1636, in test_getnameinfo_ipv6_scopeid
nameinfo = socket.getnameinfo(sockaddr, socket.NI_NUMERICHOST | socket.NI_NUMERICSERV)
socket.gaierror: [Errno 4] Non-recoverable failure in name resolution
https://bugs.python.org/issue32221