Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32598: Use autoconf to detect usable OpenSSL #5242

Merged
merged 1 commit into from
Jan 20, 2018

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 19, 2018

Add https://www.gnu.org/software/autoconf-archive/ax_check_openssl.html
to auto-detect compiler flags, linker flags and libraries to compile
OpenSSL extensions. The M4 macro uses pkg-config and falls back to
manual detection.

Add autoconf magic to detect usable X509_VERIFY_PARAM_set1_host()
and related functions.

Refactor setup.py to use new config vars to compile _ssl and _hashlib
modules.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue32598

@tiran tiran changed the title Use autoconf to detect usable OpenSSL bpo-32598: Use autoconf to detect usable OpenSSL Jan 19, 2018
@tiran tiran requested a review from vstinner January 19, 2018 13:52
Add https://www.gnu.org/software/autoconf-archive/ax_check_openssl.html
to auto-detect compiler flags, linker flags and libraries to compile
OpenSSL extensions. The M4 macro uses pkg-config and falls back to
manual detection.

Add autoconf magic to detect usable X509_VERIFY_PARAM_set1_host()
and related functions.

Refactor setup.py to use new config vars to compile _ssl and _hashlib
modules.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Copy link
Member Author

tiran commented Jan 19, 2018

The PR does not use HAVE_X509_VERIFY_PARAM_SET1_HOST. Once this PR has landed, I'll rebase #5128 and use it there.

@tiran tiran merged commit ff5be6e into python:master Jan 20, 2018
@tiran tiran deleted the openssl_autoconf branch January 20, 2018 12:19
yan12125 pushed a commit to yan12125/python3-android that referenced this pull request Jun 16, 2018
And add pkg-config settings to fix the _ssl module on CPython.

As a side note, since python/cpython#5242,
pkg-config should be correctly set up to find non-common OpenSSL paths.
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Mar 14, 2022
- macosx_sdk_specified (removed in this PR)
- find_library_functions (removed in python#5242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants