Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32521: nis libnsl #5190

Merged
merged 1 commit into from
Jan 26, 2018
Merged

bpo-32521: nis libnsl #5190

merged 1 commit into from
Jan 26, 2018

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 15, 2018 •
edited by bedevere-bot
Loading

The nismodule is now compatible with new libnsl and headers location

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue32521

@stratakis
Copy link
Contributor

Backported the PR to the Fedora build of python3 and I can confirm that the nis module compiles successfully after adding the appropriate packages, where the headers reside now, as BuildRequires (libnsl2-devel and libtirpc-devel).

vstinner
vstinner reviewed Jan 16, 2018
View reviewed changes
setup.py Outdated
library_dirs = []
includes_dirs = []

# Latest glibc has moved Sun RPC headers into tircp and nsl sub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to document the version in which the chanhe was made?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add maybe also "bpo-32521: " prefix to add even more context.

Misc/NEWS.d/next/Library/2018-01-15-12-53-13.bpo-32521.IxX4Ba.rst Outdated
@@ -0,0 +1 @@
The nismodule is now compatible with new libnsl and headers location.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, would you mind to mention the glibc version here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be version 2.26. Relevant changes
here and here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"nismodule" => "nis module"?

vstinner
vstinner approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a few remaining nit picks.

setup.py Outdated
library_dirs = []
includes_dirs = []

# glibc has deprecated Sun RPC for some time. Fedora 28 moved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may add "bpo-32521: " prefix here.

Misc/NEWS.d/next/Library/2018-01-15-12-53-13.bpo-32521.IxX4Ba.rst Outdated
@@ -0,0 +1 @@
The nismodule is now compatible with new libnsl and headers location.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"nismodule" => "nis module"?

@tiran
bpo-32521: nis libnsl
7c2b6ee 
The nismodule is now compatible with new libnsl and headers location

Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Copy link
Member Author

tiran commented Jan 26, 2018

@vstinner please review again

vstinner
vstinner approved these changes Jan 26, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tiran tiran merged commit 29a7df7 into python:master Jan 26, 2018
@bedevere-bot
Copy link

@web-flow: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@tiran tiran deleted the nis_libnsl branch January 26, 2018 22:28
@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 29a7df78277447cf6b898dfa0b1b42f8da7abc0c 3.6

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 29a7df78277447cf6b898dfa0b1b42f8da7abc0c 2.7

tiran added a commit to tiran/cpython that referenced this pull request Jan 26, 2018
@tiran
bpo-32521: nis libnsl (python#5190)
339141d 
The nismodule is now compatible with new libnsl and headers location

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 29a7df7)
tiran added a commit to tiran/cpython that referenced this pull request Jan 26, 2018
@tiran
[3.6] bpo-32521: nis libnsl (pythonGH-5190)
b5ed783 
The nismodule is now compatible with new libnsl and headers location

Signed-off-by: Christian Heimes <christian@python.org>.
(cherry picked from commit 29a7df7)
@bedevere-bot
Copy link

GH-5352 is a backport of this pull request to the 3.6 branch.

tiran added a commit to tiran/cpython that referenced this pull request Jan 26, 2018
@tiran
[2.7] bpo-32521: nis libnsl (pythonGH-5190)
8831772 
The nismodule is now compatible with new libnsl and headers location

Signed-off-by: Christian Heimes <christian@python.org>.
(cherry picked from commit 29a7df7)
@bedevere-bot
Copy link

GH-5353 is a backport of this pull request to the 2.7 branch.

@bedevere-bot
Copy link

@tiran: Please replace # with GH- in the commit message next time. Thanks!

tiran added a commit that referenced this pull request Jan 27, 2018
@tiran
[3.6] bpo-32521: nis libnsl (GH-5190) (#5352)
12ae407 
* bpo-32521: nis libnsl (#5190)

The nismodule is now compatible with new libnsl and headers location

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 29a7df7)
tiran added a commit that referenced this pull request Jan 27, 2018
@tiran
[2.7] bpo-32521: nis libnsl (GH-5190) (#5353)
38487a0 
The nismodule is now compatible with new libnsl and headers location

Signed-off-by: Christian Heimes <christian@python.org>.
(cherry picked from commit 29a7df7)
@mingwandroid
Copy link
Contributor

mingwandroid commented Apr 26, 2018 •
edited
Loading

This breaks macOS.

edit: Apologies, this is more likely a local issue with our build tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratakis stratakis stratakis left review comments

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tiran @stratakis @bedevere-bot @miss-islington @mingwandroid @vstinner @the-knights-who-say-ni