Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-26330: Document accepted values for shutil.disk_usage() #5184

Merged
merged 1 commit into from
Jan 15, 2018
Merged

bpo-26330: Document accepted values for shutil.disk_usage() #5184

merged 1 commit into from
Jan 15, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Jan 14, 2018 •
edited by bedevere-bot
Loading

giampaolo
giampaolo approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@giampaolo giampaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mariatta Mariatta added needs backport to 3.6 docs Documentation in the Doc dir skip news labels Jan 15, 2018
@Mariatta Mariatta merged commit ee3b835 into python:master Jan 15, 2018
@miss-islington
Copy link
Contributor

Thanks @csabella for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 15, 2018
@csabella @miss-islington
bpo-26330: Update shutil.disk_usage() documentation (pythonGH-5184)
df55917 
Clarify that on Windows, path must be a directory.
On Unix, path can be a file or a directory.
(cherry picked from commit ee3b835)
@bedevere-bot
Copy link

GH-5188 is a backport of this pull request to the 3.6 branch.

@csabella csabella deleted the issue26330 branch January 15, 2018 10:21
Mariatta pushed a commit that referenced this pull request Jan 15, 2018
@miss-islington @Mariatta
bpo-26330: Update shutil.disk_usage() documentation (GH-5184) (GH-5188)
fb8569e 
Clarify that on Windows, path must be a directory.
On Unix, path can be a file or a directory.
(cherry picked from commit ee3b835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giampaolo giampaolo giampaolo approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@csabella @miss-islington @bedevere-bot @giampaolo @Mariatta @the-knights-who-say-ni