Implement the get_resource_reader() API for file system imports #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brettcannon I've moved the zipimport work to a separate branch, still in progress. |
brettcannon
requested changes
Jan 12, 2018
|
When you're done making the requested changes, leave the comment: |
|
@brettcannon Didn't you just land the docs for this in bca4218 ? |
|
I have made the requested changes; please review again |
|
@brettcannon Ping. I'm rebasing my zipimporter branch on top of this one, so I'd like to land it soon. See my previous comment about the docs. |
brettcannon
approved these changes
Jan 15, 2018
|
I landed the docs for the ABC, but I didn't document anything relating to the changes in this PR. I've gone ahead and approved this so you can get your zipimporter changes in as we can do doc changes in after b1 if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.