bpo-32493: [3.7] UUID module. Not only AIX, but FreeBSD has uid_create support #5089
Conversation
but unsigned32 type does not exist but that s just a standard uint32_t type in FreeBSD.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
ghost
changed the title
ghost
changed the title
Modules/_uuidmodule.c
Outdated
| @@ -22,7 +22,7 @@ py_uuid_generate_time_safe(void) | |||
| /* | |||
| * AIX support for uuid - RFC4122 | |||
There was a problem hiding this comment.
Since this isn't AIX-only after all, can you edit this comment?
Also please edit the similar comment in configure.ac where it checks the location for uuid.h (don't forget to regenerate configure afterwards).
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
p.s. - I think you can delete aclocal.m4 from the PR. From experience, my aclocal.m4 was quite different, but that is because I did not have pkgconfig installed. Or maybe Antoine cleans that up before the PR is merged. Glad that AIX is not the only OS that uses uuid_create() et al. Although, would have been nicer (from AIX) if a developer had not invented a new typedef only for uuid stuff. (and it is uuid_ support, not uid_ :p |
|
I have made the requested changes; please review again |
|
Thank you. This looks good to me now. |
but unsigned32 type does not exist but that s just a standard
uint32_t type in FreeBSD.
https://bugs.python.org/issue32493