return the new file descriptor from os.dup2 (closes bpo-32441) #5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
force-pushed
the
benjamin-dup2-return
branch
from
4f56378 to
251d3a2
Compare
pitrou
reviewed
Dec 29, 2017
Modules/posixmodule.c
Outdated
| @@ -7855,7 +7856,7 @@ os_dup2_impl(PyObject *module, int fd, int fd2, int inheritable) | |||
|
|
|||
| #endif | |||
|
|
|||
| Py_RETURN_NONE; | |||
| return PyLong_FromLong(res); | |||
There was a problem hiding this comment.
Why don't you rely on Argument Clinic as os_dup_impl does?
There was a problem hiding this comment.
In this case, argument clinic actually complicates the error handling, but I suppose it's the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32441