Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-17611. Move unwinding of stack for "pseudo exceptions" from interpreter to compiler. #5006

Merged
merged 85 commits into from
Feb 22, 2018
Merged

bpo-17611. Move unwinding of stack for "pseudo exceptions" from interpreter to compiler. #5006

merged 85 commits into from
Feb 22, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 24, 2017 •
edited by bedevere-bot
Loading

pitrou and others added 30 commits December 24, 2017 15:43
@pitrou @serhiy-storchaka
bpo-17611: Move unwinding of stack from interpreter to compiler
2315076
@pitrou @serhiy-storchaka
Cleanup
b160900
@pitrou @serhiy-storchaka
Improve stack size calculation for SETUP_{EXCEPT,FINALLY}
9833631
@pitrou @serhiy-storchaka
Update frozen importlib
9116fb8
@pitrou @serhiy-storchaka
Remove useless code
5b3796e
@pitrou @serhiy-storchaka
Don't predict FOR_ITER as it breaks tracing without computed gotos
77caab0
@pitrou @serhiy-storchaka
Remove dead code and fix tracing tests
9fffb61
@pitrou @serhiy-storchaka
Fix test_dis
5fe5e1b
@pitrou @serhiy-storchaka
Add JUMP_FINALLY to avoid finally block duplication
a93f2e2
@pitrou @serhiy-storchaka
Remove finally block duplication
b007b1c
@pitrou @serhiy-storchaka
More precise computation of code object stack size
0bcf8a7
@pitrou @serhiy-storchaka
JUMP_FINALLY pushes 6 values to be consistent with the effect of an e…
eecf02f 
…xception
@pitrou @serhiy-storchaka
Exact stack size computation by popping stale exception state in RERAISE
64225ce
@pitrou @serhiy-storchaka
Remove the now pointless POP_MANY
04e055e
@pitrou @serhiy-storchaka
Add comment for RERAISE
a3e1b80
@pitrou @serhiy-storchaka
Remove JUMP_FINALLY
a049635
@pitrou @serhiy-storchaka
Remove last block duplication
0741d02
@pitrou @serhiy-storchaka
Get rid of END_ITER
5493616
@pitrou @serhiy-storchaka
Fix comments in frameobject.c
5c68acf
@pitrou @serhiy-storchaka
Add stack size tests
2d41c17
@serhiy-storchaka
Fix test_dis.
afc2235
@serhiy-storchaka
Simplify handling of 'for' loops in frame_setlineno() and fix it for …
00a6681 
…long opargs.
@serhiy-storchaka
Do not duplicate the finally block.
f8cc274
@serhiy-storchaka
Refactor the frame unwinding code.
160ce37
@serhiy-storchaka
Refactoring and optimizations in the compiler.
b3b3250
@serhiy-storchaka
Fix frame_setlineno().
e3f5099
@serhiy-storchaka
Rename PUSH_NO_EXCEPT to BEGIN_FINALLY.
d8dd38d
@serhiy-storchaka
Restore SETUP_WITH and SETUP_ASYNC_WITH.
f1d0bc9
@serhiy-storchaka
Fix stack depth calculation.
84c6400
@serhiy-storchaka
Remove SETUP_EXCEPT.
35bd61b
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 9, 2018
Closed
@serhiy-storchaka serhiy-storchaka requested a review from a team as a code owner February 4, 2018 10:11
@serhiy-storchaka
Copy link
Member Author

I think I have addressed all comments. The code is updated to 3.8, all tests are passes. What should I do for moving this PR forward?

@pitrou
Copy link
Member

pitrou commented Feb 12, 2018

I suppose you need a review? Given the size of the PR it's not easy to find time for it...

@serhiy-storchaka
Copy link
Member Author

Yes, even after simplifications and merging some changes separately the PR still is too complex.

Could you please make at least a quick review? I think we are agree with the design, the known bugs was fixed, and if there are some minor bugs are left, we will have time to catch them in live code.

Merging this PR will unblock other changes: cleaning up with-related opcodes (#5112 or like) and allowing 'continue' in 'finally' clause (bpo-32489, serhiy-storchaka#2).

@pitrou
Copy link
Member

pitrou commented Feb 13, 2018

Yes, I'm gonna make a quick review ;-)

@pitrou pitrou dismissed their stale review February 22, 2018 20:02

review is out of date

pitrou
pitrou approved these changes Feb 22, 2018
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I haven't looked very closely this time, but declare this to look ok :-)

@serhiy-storchaka
Copy link
Member Author

Thanks Antoine!

@serhiy-storchaka serhiy-storchaka merged commit 520b7ae into python:master Feb 22, 2018
@serhiy-storchaka serhiy-storchaka deleted the unwind_stack branch March 18, 2018 07:58
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @pitrou @nascheme @bedevere-bot @the-knights-who-say-ni