bpo-32379: Faster MRO computation for single inheritance #4932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objects/typeobject.c
Outdated
| @@ -1979,7 +2006,6 @@ mro_internal(PyTypeObject *type, PyObject **p_old_mro) | |||
| return 1; | |||
| } | |||
|
|
|||
|
|
|||
| return NULL; | ||
| } | ||
| k = PyTuple_GET_SIZE(base->tp_mro); | ||
| result = PyTuple_New(k + 1); |
There was a problem hiding this comment.
Shouldn't the result be a tuple?
There was a problem hiding this comment.
You mean a list? The caller calls PySequence_Tuple on the result, so it's faster if we create a tuple upfront.
serhiy-storchaka
approved these changes
Dec 20, 2017
Objects/typeobject.c
Outdated
| return mro_implementation(self); | ||
| PyObject *seq; | ||
| seq = mro_implementation(self); | ||
| if (seq != NULL && PyTuple_CheckExact(seq)) { |
There was a problem hiding this comment.
I would write !PyList_Check().
Objects/typeobject.c
Outdated
| PyObject *seq; | ||
| seq = mro_implementation(self); | ||
| if (seq != NULL && PyTuple_CheckExact(seq)) { | ||
| PyObject *lst = PySequence_List(seq); |
There was a problem hiding this comment.
This may look clearer with
Py_SETREF(seq, PySequence_List(seq));and a single return.
There was a problem hiding this comment.
I have to get used to it :-)
|
Thanks for the review @serhiy-storchaka ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32379