Skip KqueueEventLoopTests.test_read_pty_output test on MacOS. #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I don't use MacOSX -- but the change looks harmless |
asvetlov
approved these changes
Dec 10, 2017
1st1
force-pushed
the
skip_hanging_test
branch
from
f7875e2 to
2c12de5
Compare
Starting with 10.13.2 the test hangs forever.
1st1
force-pushed
the
skip_hanging_test
branch
from
2c12de5 to
2e2e263
Compare
vstinner
reviewed
Dec 11, 2017
Lib/test/test_asyncio/test_events.py
Outdated
| # Issue #20667: KqueueEventLoopTests.test_read_pty_output() | ||
| # hangs on OpenBSD 5.5 | ||
| @unittest.skipIf(sys.platform.startswith('openbsd'), | ||
| 'test hangs on OpenBSD') | ||
| @unittest.skipIf(sys.platform == 'darwin', |
There was a problem hiding this comment.
I would like to see the rationale for the skip. Would you to open an issue? Maybe add the bpo number in a comment?
|
Oh, I had a draft comment but I forgot to sent it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 10.13.2 the test hangs forever. Since its already masked on OpenBSD, it seems that the problem is known and common.