Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32098: Fix hardcoded value in test_os.py #4744

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 7, 2017

@merwok
Copy link
Member

merwok commented Dec 7, 2017

I think this PR has the wrong bug number.

@pablogsal pablogsal changed the title bpo-31972: Fix hardcoded value in test_os.py bpo-32098: Fix hardcoded value in test_os.py Dec 7, 2017
@pablogsal
Copy link
Member Author

Indeed, the correct one is 32098. My bad.

@pablogsal
Copy link
Member Author

@merwok Thanks for the catch!

@vstinner vstinner merged commit fb77e0d into python:master Dec 7, 2017
@vstinner
Copy link
Member

vstinner commented Dec 7, 2017

Thank you for your contribution ;-)

@vstinner
Copy link
Member

vstinner commented Dec 7, 2017

Oops, I missed the fact that the bpo number was missing in the commit message. It's still surprised that the Pull Request title and descript are different than the "generated" commit message when I press [Merge]. Sometimes I forget to check, like for this PR. It doesn't matter, it's a trivial fix.

@pablogsal pablogsal deleted the bpo31972 branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants