[bpo-28556] Minor fixes for typing module #4710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Dec 5, 2017
|
Thanks @ilevkivskyi for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2017
(cherry picked from commit 29bc193)
|
GH-4713 is a backport of this pull request to the 3.6 branch. |
|
Merged into master for 3.7.0 and into 3.6 for 3.6.4. 3.5 is now in security-fix only mode so presumably these changes would not go there. |
|
@ned-deily Thank you for fast reaction! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be backported to 3.5 and 3.6.
cc: @gvanrossum
@ned-deily if possible, I think it would make sense to include these fixes in 3.6.4rc1
https://bugs.python.org/issue28556