Skip to content

bpo-20891: Py_Initialize() now creates the GIL #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 29, 2018
Merged

bpo-20891: Py_Initialize() now creates the GIL #4700

merged 4 commits into from
Jan 29, 2018

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 4, 2017 •
edited by bedevere-bot
Loading

The GIL is not more created "on demand" to fix a race condition when
PyGILState_Ensure() is called in a non-Python thread.

https://bugs.python.org/issue20891

@vstinner vstinner requested a review from pitrou December 4, 2017 17:35
pitrou
pitrou reviewed Dec 4, 2017
View reviewed changes
Misc/NEWS.d/next/Core and Builtins/2017-12-04-18-34-11.bpo-20891.C2TsfR.rst Outdated
Copy link
Member

@pitrou pitrou Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/not more/no more/

Copy link
Member Author

@vstinner vstinner Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, replaced with "no longer"

@pitrou
Copy link
Member

pitrou commented Dec 4, 2017

Is there any documentation to update?

@vstinner
Copy link
Member Author

vstinner commented Dec 4, 2017

Is there any documentation to update?

Done, see my updated PR.

pitrou
pitrou reviewed Dec 4, 2017
View reviewed changes
Doc/c-api/init.rst Outdated
Copy link
Member

@pitrou pitrou Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would phrase it more explicitly:

This function is now called by :c:func:`Py_Initialize()`, so you don't have to call it yourself anymore.

Copy link
Member Author

@vstinner vstinner Jan 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@warsaw
Copy link
Member

warsaw commented Dec 15, 2017

This branch seems to fix the issue for me on macOS 10.12.6

@vstinner
Copy link
Member Author

vstinner commented Dec 18, 2017

For benchmark results, see https://bugs.python.org/issue20891#msg308588

@vstinner
bpo-20891: Py_Initialize() now creates the GIL
8cd30d6 
The GIL is no longer created "on demand" to fix a race condition when
PyGILState_Ensure() is called in a non-Python thread.
@vstinner
Update the documentation
ec26869 
Remove also mention of the "thread support", since thread support
cannot be disabled anymore.
@vstinner
Simplify PyEval_SaveThread/PyEval_RestoreThread
0caeef0 
Make the assumption that the GIL is always created (by
Py_Initialize()).
@vstinner
doc: rephrase versionchanged
b8b3a1d
@vstinner vstinner merged commit 2914bb3 into python:master Jan 29, 2018
@bedevere-bot
Copy link

bedevere-bot commented Jan 29, 2018

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@vstinner vstinner deleted the gil_created branch January 29, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @pitrou @warsaw @bedevere-bot @the-knights-who-say-ni