Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in asyncio.streams.FlowControlMixin documentation #4578

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

johnchen902
Copy link
Contributor

No description provided.

@johnchen902 johnchen902 requested a review from 1st1 as a code owner November 27, 2017 03:46
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@johnchen902 johnchen902 changed the title Fix asyncio.streams.FlowControlMixin docstring typo. Fix typo in asyncio.streams.FlowControlMixin documentation Nov 27, 2017
@asvetlov
Copy link
Contributor

@joelthelion the patch is good but please sign a Contributor Agreement: https://www.python.org/psf/contrib/contrib-form/

Without this step I cannot merge the Pull Request, it is Python's policy.
Thanks.

@asvetlov asvetlov self-assigned this Nov 30, 2017
@joelthelion
Copy link
Contributor

@asvetlov I think you got the wrong person.

@asvetlov
Copy link
Contributor

Sorry, autocomplete is not always perfect.

@asvetlov
Copy link
Contributor

@johnchen902 please sign a Contributor Agreement: https://www.python.org/psf/contrib/contrib-form/

@johnchen902
Copy link
Contributor Author

I signed one right before sending this pull request.

Contributor Form Received | Yes on: 2017-11-27.08:00:00

@asvetlov
Copy link
Contributor

asvetlov commented Dec 1, 2017

Thanks!
Processing CLA is not automatic, a person should review all CLAs.
Let's wait for a few days.

@johnchen902
Copy link
Contributor Author

I thought mine has been reviewed, but the 'cla-not-signed' label has to be removed for @the-knights-who-say-ni to recheck.

@asvetlov
Copy link
Contributor

asvetlov commented Dec 1, 2017

Aha, I see that CLA is signed on https://bugs.python.org/user27450

@asvetlov
Copy link
Contributor

asvetlov commented Dec 1, 2017

Thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants