Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-32137: The repr of deeply nested dict now raises a RecursionError #4570

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 26, 2017

instead of crashing due to a stack overflow.

This perhaps fixes similar problems in other extension types.

https://bugs.python.org/issue32137

instead of crashing due to a stack overflow.

This perhaps fixes similar problems in other extension types.
@serhiy-storchaka serhiy-storchaka added needs backport to 2.7 type-bug An unexpected behavior, bug, or error labels Nov 26, 2017
@serhiy-storchaka serhiy-storchaka merged commit 1fb72d2 into python:master Dec 3, 2017
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-4689 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 3, 2017
…pythonGH-4570)

instead of crashing due to a stack overflow.

This perhaps will fix similar problems in other extension types.
(cherry picked from commit 1fb72d2)
@serhiy-storchaka serhiy-storchaka deleted the repr-recursion-limit branch December 3, 2017 20:12
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1fb72d2ad243c965d4432b4e93884064001a2607 2.7

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 12, 2017
…nError (pythonGH-4570)

instead of crashing due to a stack overflow.

This perhaps will fix similar problems in other extension types.
(cherry picked from commit 1fb72d2)
serhiy-storchaka pushed a commit that referenced this pull request Feb 1, 2018
…GH-4570) (GH-4689)

instead of crashing due to a stack overflow.

This perhaps will fix similar problems in other extension types.
(cherry picked from commit 1fb72d2)
@bedevere-bot
Copy link

GH-5493 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 2, 2018
…nError (pythonGH-4570)

instead of crashing due to a stack overflow.

This perhaps will fix similar problems in other extension types.
(cherry picked from commit 1fb72d2)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Feb 2, 2018
…rror (GH-4570) (#5493)

instead of crashing due to a stack overflow.

This perhaps will fix similar problems in other extension types.
(cherry picked from commit 1fb72d2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants