bpo-32136: Separate embedding tests from C API tests #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some parts of the C API are only relevant to larger applications embedding CPython as a runtime engine. The helpers to test those APIs are already separated out into Programs/_testembed.c, this update moves the associated test cases out into their own dedicated test file.
vstinner
reviewed
Nov 27, 2017
| import re | ||
| import subprocess | ||
| import sys | ||
|
|
There was a problem hiding this comment.
Would you mind to add an empty line for PEP8, please? :-)
| @@ -420,190 +420,6 @@ def test(self): | |||
| self.assertEqual(_testcapi.argparsing("Hello", "World"), 1) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
pyflakes found 2 unused imports:
Lib/test/test_capi.py:4:1: F401 'collections.namedtuple' imported but unused
Lib/test/test_capi.py:7:1: F401 'platform' imported but unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of the C API are only relevant to larger
applications embedding CPython as a runtime engine.
The helpers to test those APIs are already separated
out into Programs/_testembed.c, this update moves
the associated test cases out into their own dedicated
test file.
https://bugs.python.org/issue32136