Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordering #4541

Merged
merged 1 commit into from Nov 24, 2017
Merged

Ordering #4541

merged 1 commit into from Nov 24, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2017

See #4490.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta Mariatta merged commit 78a5722 into python:master Nov 24, 2017
@miss-islington
Copy link
Contributor

Thanks @willnwhite for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Thanks @willnwhite and congrats on your first contribution to CPython 🌮

@Mariatta
Copy link
Member

Please do sign the CLA for your future contributions. :)

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2017
@miss-islington
Improve the String tutorial docs (pythonGH-4541)
9447f2c 
The paragraph that contains example of string literal concatenation was placed
after the section about concatenation using the '+' sign.
Moved the paragraph to the appropriate section.
(cherry picked from commit 78a5722)
@bedevere-bot
Copy link

GH-4545 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

GH-4546 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2017
@miss-islington
Improve the String tutorial docs (pythonGH-4541)
67c3053 
The paragraph that contains example of string literal concatenation was placed
after the section about concatenation using the '+' sign.
Moved the paragraph to the appropriate section.
(cherry picked from commit 78a5722)
Mariatta pushed a commit that referenced this pull request Nov 24, 2017
@miss-islington @Mariatta
Improve the String tutorial docs (GH-4541) (GH-4545)
7b909a9 
The paragraph that contains example of string literal concatenation was placed
after the section about concatenation using the '+' sign.
Moved the paragraph to the appropriate section.
(cherry picked from commit 78a5722)
Mariatta pushed a commit that referenced this pull request Nov 24, 2017
@miss-islington @Mariatta
Improve the String tutorial docs (GH-4541) (GH-4546)
465f3d0 
The paragraph that contains example of string literal concatenation was placed
after the section about concatenation using the '+' sign.
Moved the paragraph to the appropriate section.
(cherry picked from commit 78a5722)
@ghost ghost deleted the patch-2 branch November 24, 2017 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-knights-who-say-ni @miss-islington @Mariatta @bedevere-bot